* [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor
@ 2023-09-22 1:12 Matti Lehtimäki
2023-09-22 16:24 ` Luca Weiss
2023-09-28 0:34 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Matti Lehtimäki @ 2023-09-22 1:12 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel
Fix hall sensor GPIO polarity and also allow disabling the sensor.
Remove unneeded interrupt.
Fixes: f15623bda1dc ("ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 (SM-T530)")
Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
---
arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
index 884d99297d4c..f516e0426bb9 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
+++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
@@ -45,11 +45,11 @@ gpio-hall-sensor {
event-hall-sensor {
label = "Hall Effect Sensor";
- gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
- interrupts = <&tlmm 110 IRQ_TYPE_EDGE_FALLING>;
+ gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
linux,input-type = <EV_SW>;
linux,code = <SW_LID>;
debounce-interval = <15>;
+ linux,can-disable;
wakeup-source;
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor
2023-09-22 1:12 [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor Matti Lehtimäki
@ 2023-09-22 16:24 ` Luca Weiss
2023-09-28 0:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Luca Weiss @ 2023-09-22 16:24 UTC (permalink / raw)
To: linux-arm-msm, ~postmarketos/upstreaming
Cc: ~postmarketos/upstreaming, phone-devel, Matti Lehtimäki,
Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-kernel,
Matti Lehtimäki
On Freitag, 22. September 2023 03:12:11 CEST Matti Lehtimäki wrote:
> Fix hall sensor GPIO polarity and also allow disabling the sensor.
> Remove unneeded interrupt.
>
> Fixes: f15623bda1dc ("ARM: dts: qcom: Add support for Samsung Galaxy Tab 4
> 10.1 (SM-T530)")
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
Reviewed-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index
> 884d99297d4c..f516e0426bb9 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts
> @@ -45,11 +45,11 @@ gpio-hall-sensor {
>
> event-hall-sensor {
> label = "Hall Effect Sensor";
> - gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>;
> - interrupts = <&tlmm 110 IRQ_TYPE_EDGE_FALLING>;
> + gpios = <&tlmm 110 GPIO_ACTIVE_LOW>;
> linux,input-type = <EV_SW>;
> linux,code = <SW_LID>;
> debounce-interval = <15>;
> + linux,can-disable;
> wakeup-source;
> };
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor
2023-09-22 1:12 [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor Matti Lehtimäki
2023-09-22 16:24 ` Luca Weiss
@ 2023-09-28 0:34 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2023-09-28 0:34 UTC (permalink / raw)
To: linux-arm-msm, Matti Lehtimäki
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel
On Fri, 22 Sep 2023 04:12:11 +0300, Matti Lehtimäki wrote:
> Fix hall sensor GPIO polarity and also allow disabling the sensor.
> Remove unneeded interrupt.
>
>
Applied, thanks!
[1/1] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor
commit: 0b73519790d29e4bc71afc4882a9aa9ea649bcf7
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-28 0:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 1:12 [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Fix inverted hall sensor Matti Lehtimäki
2023-09-22 16:24 ` Luca Weiss
2023-09-28 0:34 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).