From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FB7E41771 for ; Fri, 22 Sep 2023 16:08:08 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCD3899; Fri, 22 Sep 2023 09:08:07 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7715EB53; Fri, 22 Sep 2023 18:06:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1695398787; bh=Xs3HJJWVKmjQFBtIkxcpfdhvwl2YfTPFfT5f3BfS2P4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t73D12u6qC9MwrL4EN+MJkqQgp8Rs+xx1TrYWHeuwHkDYx6/IRBk+tcFmwEQp2yDF xUu+ANq5DNzWHpse7/U/0k6LIx7krIxAb3UQ9SblPw+J9fqW5N8uET3qKi1EKGQDcG hGHEk39Slm/akpi8hzrc/Gc9BJSt4dU8Yipks9ns= Date: Fri, 22 Sep 2023 19:08:18 +0300 From: Laurent Pinchart To: Alain Volmat Cc: Hugues Fruchet , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Russell King , Philipp Zabel , Sakari Ailus , Dan Scally , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] ARM: dts: stm32: add dcmipp support to stm32mp135 Message-ID: <20230922160818.GJ19112@pendragon.ideasonboard.com> References: <20230901155732.252436-1-alain.volmat@foss.st.com> <20230901155732.252436-5-alain.volmat@foss.st.com> <20230905090258.GC31594@pendragon.ideasonboard.com> <20230922160227.GA608616@gnbcxd0016.gnb.st.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230922160227.GA608616@gnbcxd0016.gnb.st.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Sep 22, 2023 at 06:02:27PM +0200, Alain Volmat wrote: > On Tue, Sep 05, 2023 at 12:02:58PM +0300, Laurent Pinchart wrote: > > On Fri, Sep 01, 2023 at 05:57:23PM +0200, Alain Volmat wrote: > > > From: Hugues Fruchet > > > > > > Add dcmipp support to STM32MP135. > > > > > > Signed-off-by: Hugues Fruchet > > > Signed-off-by: Alain Volmat > > > --- > > > arch/arm/boot/dts/st/stm32mp135.dtsi | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/st/stm32mp135.dtsi b/arch/arm/boot/dts/st/stm32mp135.dtsi > > > index abf2acd37b4e..beee9ec7ed0d 100644 > > > --- a/arch/arm/boot/dts/st/stm32mp135.dtsi > > > +++ b/arch/arm/boot/dts/st/stm32mp135.dtsi > > > @@ -8,5 +8,13 @@ > > > > > > / { > > > soc { > > > + dcmipp: dcmipp@5a000000 { > > > + compatible = "st,stm32mp13-dcmipp"; > > > + reg = <0x5a000000 0x400>; > > > + interrupts = ; > > > + resets = <&rcc DCMIPP_R>; > > > + clocks = <&rcc DCMIPP_K>; > > > + status = "disabled"; > > > > This needs a port, as it's marked as required in the bindings. You can > > leave the endpoint out. > > I first agreed with your comment but, having done the check (make > CHECK_DTBS=y ...) this doesn't seem to be required because the dcmipp > node is kept disabled within our dtsi. Interesting. > (it is later on only enabled in dts file which as well have the port > property). > Indeed, to check this I changed it to okay and DTC_CHK complained about > missing port property. > > Hence, I'd think that port doesn't have to be added in this dtsi file. > Would you agree with that ? I still think the port belongs here, as it's an intrinsic property of the dcmipp, not a property of the board. Does it cause any issue to add a port in the .dtsi ? > > With this fixed, > > > > Reviewed-by: Laurent Pinchart > > > > > + }; > > > }; > > > }; -- Regards, Laurent Pinchart