From: Rob Herring <robh@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, Ninad Malwade <nmalwade@nvidia.com>
Subject: Re: [PATCH V3 2/4] dt-bindings: hwmon: ina3221: Add ti,summation-disable
Date: Fri, 22 Sep 2023 16:06:31 -0500 [thread overview]
Message-ID: <20230922210631.GA3569506-robh@kernel.org> (raw)
In-Reply-To: <20230921130818.21247-3-jonathanh@nvidia.com>
On Thu, Sep 21, 2023 at 02:08:16PM +0100, Jon Hunter wrote:
> The INA3221 has a critical alert pin that can be controlled by the
> summation control function. This function adds the single
> shunt-voltage conversions for the desired channels in order to
> compare the combined sum to the programmed limit. The Shunt-Voltage
> Sum Limit register contains the programmed value that is compared
> to the value in the Shunt-Voltage Sum register in order to
> determine if the total summed limit is exceeded. If the
> shunt-voltage sum limit value is exceeded, the critical alert pin
> pulls low.
>
> For the summation limit to have a meaningful value, it is necessary
> to use the same shunt-resistor value on all included channels. Add a new
> vendor specific property, 'ti,summation-disable', to allow specific
> channels to be excluded from the summation control function if the shunt
> resistor is different to other channels or the channel should not be
> considered for triggering the critical alert pin.
You are adding this feature to the driver, but requiring a new property
to disable it. So what happens with an existing user (old DT) and a
kernel with the new feature?
Rob
next prev parent reply other threads:[~2023-09-22 21:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 13:08 [PATCH V3 0/4] hwmon: ina3221: Add selective summation support Jon Hunter
2023-09-21 13:08 ` [PATCH V3 1/4] dt-bindings: hwmon: ina3221: Convert to json-schema Jon Hunter
2023-09-22 21:01 ` Rob Herring
2023-09-25 10:46 ` Jon Hunter
2023-09-26 9:18 ` Conor Dooley
2023-09-26 12:02 ` Jon Hunter
2023-09-21 13:08 ` [PATCH V3 2/4] dt-bindings: hwmon: ina3221: Add ti,summation-disable Jon Hunter
2023-09-22 21:06 ` Rob Herring [this message]
2023-09-25 10:50 ` Jon Hunter
2023-09-21 13:08 ` [PATCH V3 3/4] hwmon: ina3221: Add support for channel summation disable Jon Hunter
2023-09-21 21:11 ` kernel test robot
2023-09-21 13:08 ` [PATCH V3 4/4] arm64: tegra: Add power-sensors for Tegra234 boards Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922210631.GA3569506-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nmalwade@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).