From: Rob Herring <robh@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>,
thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 3/3] dt-bindings: pwm: mxs: Allow passing #pwm-cells = <2>
Date: Fri, 22 Sep 2023 16:17:37 -0500 [thread overview]
Message-ID: <20230922211737.GA3628801-robh@kernel.org> (raw)
In-Reply-To: <20230921195909.ulpoqvrixocwqou2@pengutronix.de>
On Thu, Sep 21, 2023 at 09:59:09PM +0200, Uwe Kleine-König wrote:
> Hello Fabio,
>
> On Thu, Sep 21, 2023 at 03:43:48PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > All the in-tree imx23 and imx28 devicetrees use #pwm-cells = <2>.
> >
> > Allow it in the schema to avoid warnings.
> >
> > It is still possible for a devicetree to pass the third cell with the
> > PWM polarity though.
> >
> > This is similar to imx-pwm.yaml that allows #pwm-cells to be 2 or 3.
>
> Alternatively switch all devicetrees to use = <3>? That's what I'd
> prefer given that the PWM supports both polarities.
Technically, that could break older clients predating 3 cell support.
But maybe that's far back enough now to not care. Either way,
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-09-22 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 18:43 [PATCH 1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm Fabio Estevam
2023-09-21 18:43 ` [PATCH 2/3] dt-bindings: pwm: mxs: Document the clocks property Fabio Estevam
2023-09-21 20:07 ` Uwe Kleine-König
2023-09-22 11:31 ` Conor Dooley
2023-09-21 18:43 ` [PATCH 3/3] dt-bindings: pwm: mxs: Allow passing #pwm-cells = <2> Fabio Estevam
2023-09-21 19:59 ` Uwe Kleine-König
2023-09-22 21:17 ` Rob Herring [this message]
2023-09-21 19:59 ` [PATCH 1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922211737.GA3628801-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).