From: Abdel Alkuor <alkuor@gmail.com>
To: heikki.krogerus@linux.intel.com,
krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
ryan.eleceng@gmail.com, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: [PATCH v6 06/14] USB: typec: Clear dead battery flag
Date: Sat, 23 Sep 2023 03:39:51 -0400 [thread overview]
Message-ID: <20230923073959.86660-7-alkuor@gmail.com> (raw)
In-Reply-To: <20230923073959.86660-1-alkuor@gmail.com>
From: Abdel Alkuor <abdelalkuor@geotab.com>
Dead battery flag must be cleared after switching tps25750 to APP mode
so the PD controller becomes fully functional.
Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
---
Changes in v6:
- No changes
Changes in v5:
- Incorporating tps25750 into tps6598x driver
drivers/usb/typec/tipd/core.c | 16 ++++++++++++++++
drivers/usb/typec/tipd/tps6598x.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 7c08669400a8..148b237d0df5 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -934,6 +934,22 @@ static int tps25750_apply_patch(struct tps6598x *tps)
} while (ret != TPS_MODE_APP);
+ /*
+ * The dead battery flag may be triggered when the controller
+ * port is connected to a device that can source power and
+ * attempts to power up both the controller and the board it is on.
+ * To restore controller functionality, it is necessary to clear
+ * this flag
+ */
+ if (status & TPS_BOOT_STATUS_DEAD_BATTERY_FLAG) {
+ ret = tps6598x_exec_cmd(tps, "DBfg", 0, NULL, 0, NULL);
+ if (ret) {
+ dev_err(tps->dev,
+ "failed to clear dead battery %d\n", ret);
+ return ret;
+ }
+ }
+
dev_info(tps->dev, "controller switched to \"APP\" mode\n");
return 0;
diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
index a80d0929f3ee..c000170f4547 100644
--- a/drivers/usb/typec/tipd/tps6598x.h
+++ b/drivers/usb/typec/tipd/tps6598x.h
@@ -200,6 +200,7 @@
#define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_B (BIT(2) | BIT(1))
/* BOOT STATUS REG*/
+#define TPS_BOOT_STATUS_DEAD_BATTERY_FLAG BIT(2)
#define TPS_BOOT_STATUS_I2C_EEPROM_PRESENT BIT(3)
#endif /* __TPS6598X_H__ */
--
2.34.1
next prev parent reply other threads:[~2023-09-23 7:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 7:39 [PATCH v6 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-23 11:49 ` Krzysztof Kozlowski
2023-09-23 7:39 ` [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay Abdel Alkuor
2023-09-27 7:00 ` Heikki Krogerus
2023-09-27 7:18 ` Heikki Krogerus
2023-09-27 7:47 ` Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 03/14] USB: typec: Add patch mode to tps6598x Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 04/14] USB: typec: Load TPS25750 patch bundle Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 05/14] USB: typec: Check for EEPROM present Abdel Alkuor
2023-09-23 7:39 ` Abdel Alkuor [this message]
2023-09-23 7:39 ` [PATCH v6 07/14] USB: typec: Apply patch again after power resume Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 08/14] USB: typec: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 09/14] USB: typec: Refactor tps6598x port registration Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 10/14] USB: typec: Add port registration for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 11/14] USB: typec: Enable sleep mode " Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 12/14] USB: typec: Add trace for tps25750 irq Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 13/14] USB: typec: Add power status trace for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 14/14] USB: typec: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230923073959.86660-7-alkuor@gmail.com \
--to=alkuor@gmail.com \
--cc=abdelalkuor@geotab.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).