* [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk
@ 2023-08-13 16:40 Adam Ford
2023-08-13 23:26 ` Fabio Estevam
2023-09-24 12:46 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Adam Ford @ 2023-08-13 16:40 UTC (permalink / raw)
To: linux-arm-kernel
Cc: aford, Adam Ford, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Geert Uytterhoeven, Magnus Damm, devicetree,
linux-kernel, linux-renesas-soc
There is a I2C controlled 100MHz Reference clock used by the PCIe
controller. Configure this clock's DIF1 output to be used by
the PCIe.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
V2: Remove the pcie0_refclk clock that the new one replaces.
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
index acd265d8b58e..a8ccde678c33 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
@@ -23,6 +23,12 @@ chosen {
stdout-path = &uart2;
};
+ clk_xtal25: clk-xtal25 {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
connector {
compatible = "usb-c-connector";
label = "USB-C";
@@ -112,12 +118,6 @@ led-3 {
};
};
- pcie0_refclk: clock-pcie {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <100000000>;
- };
-
reg_audio: regulator-wm8962 {
compatible = "regulator-fixed";
regulator-name = "3v3_aud";
@@ -246,6 +246,13 @@ pca6416_3: gpio@20 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pcieclk: clk@68 {
+ compatible = "renesas,9fgv0241";
+ reg = <0x68>;
+ clocks = <&clk_xtal25>;
+ #clock-cells = <1>;
+ };
};
&i2c3 {
@@ -372,8 +379,9 @@ &pcie {
};
&pcie_phy {
+ fsl,clkreq-unsupported;
fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
- clocks = <&pcie0_refclk>;
+ clocks = <&pcieclk 1>;
clock-names = "ref";
status = "okay";
};
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk
2023-08-13 16:40 [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk Adam Ford
@ 2023-08-13 23:26 ` Fabio Estevam
2023-09-24 12:46 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-08-13 23:26 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team, Geert Uytterhoeven, Magnus Damm, devicetree,
linux-kernel, linux-renesas-soc
On Sun, Aug 13, 2023 at 1:40 PM Adam Ford <aford173@gmail.com> wrote:
>
> There is a I2C controlled 100MHz Reference clock used by the PCIe
> controller. Configure this clock's DIF1 output to be used by
> the PCIe.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2: Remove the pcie0_refclk clock that the new one replaces.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk
2023-08-13 16:40 [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk Adam Ford
2023-08-13 23:26 ` Fabio Estevam
@ 2023-09-24 12:46 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-09-24 12:46 UTC (permalink / raw)
To: Adam Ford
Cc: linux-arm-kernel, aford, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Geert Uytterhoeven, Magnus Damm,
devicetree, linux-kernel, linux-renesas-soc
On Sun, Aug 13, 2023 at 11:40:03AM -0500, Adam Ford wrote:
> There is a I2C controlled 100MHz Reference clock used by the PCIe
> controller. Configure this clock's DIF1 output to be used by
> the PCIe.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2: Remove the pcie0_refclk clock that the new one replaces.
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
> index acd265d8b58e..a8ccde678c33 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
> @@ -23,6 +23,12 @@ chosen {
> stdout-path = &uart2;
> };
>
> + clk_xtal25: clk-xtal25 {
clock-xtal25 for the node name?
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> connector {
> compatible = "usb-c-connector";
> label = "USB-C";
> @@ -112,12 +118,6 @@ led-3 {
> };
> };
>
> - pcie0_refclk: clock-pcie {
> - compatible = "fixed-clock";
> - #clock-cells = <0>;
> - clock-frequency = <100000000>;
> - };
> -
> reg_audio: regulator-wm8962 {
> compatible = "regulator-fixed";
> regulator-name = "3v3_aud";
> @@ -246,6 +246,13 @@ pca6416_3: gpio@20 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pcieclk: clk@68 {
clock-generator in the bindings example seems a better node name to me.
Shawn
> + compatible = "renesas,9fgv0241";
> + reg = <0x68>;
> + clocks = <&clk_xtal25>;
> + #clock-cells = <1>;
> + };
> };
>
> &i2c3 {
> @@ -372,8 +379,9 @@ &pcie {
> };
>
> &pcie_phy {
> + fsl,clkreq-unsupported;
> fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
> - clocks = <&pcie0_refclk>;
> + clocks = <&pcieclk 1>;
> clock-names = "ref";
> status = "okay";
> };
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-24 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-13 16:40 [PATCH V2] arm64: dts: imx8mp-beacon: Configure 100MHz PCIe Ref Clk Adam Ford
2023-08-13 23:26 ` Fabio Estevam
2023-09-24 12:46 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).