[PATCH v2 0/2] Various TQMa6UL/MBa6ULx fixes

[PATCH v2 0/2] Various TQMa6UL/MBa6ULx fixes

[Alexander Stein]

Hi,
this is a follow up to v1 for fixing dtbs_check warnings for TQMa6UL/MBa6ULx.
While Patch 1 & 3 from v1 have been applied, Patch 2 is inserted into this v2
again. The patch itself is not changed, because a dependent patch was missing
in v1. This one has been included in v2.

Changes in v2:
* Add a missing dependent patch as new patch 1

Best regards,
Alexander

Alexander Stein (2):
  ARM: dts: imx6ul: mba6ulx: Mark gpio-buttons as wakeup-source
  ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH v2 1/2] ARM: dts: imx6ul: mba6ulx: Mark gpio-buttons as wakeup-source

[Alexander Stein]

I2C expander is capable of generating an IRQ during powersave, so the
attached buttons can be used for waking up the system.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
index ebf97fcdd8ea..632ceadcca41 100644
--- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
@@ -39,18 +39,21 @@ button1 {
 			label = "s14";
 			linux,code = <KEY_1>;
 			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 
 		button2 {
 			label = "s6";
 			linux,code = <KEY_2>;
 			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 
 		button3 {
 			label = "s7";
 			linux,code = <KEY_3>;
 			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;
+			wakeup-source;
 		};
 
 		power-button {
-- 
2.34.1

[PATCH v2 2/2] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

[Alexander Stein]

Numbers are separated by dashes. Fixes the warnings:
arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
'button1', 'button2', 'button3' do not match any of the regexes:
'^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
 from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
index 632ceadcca41..5a8b867d7d79 100644
--- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
@@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_buttons>;
 
-		button1 {
+		button-1 {
 			label = "s14";
 			linux,code = <KEY_1>;
 			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
 			wakeup-source;
 		};
 
-		button2 {
+		button-2 {
 			label = "s6";
 			linux,code = <KEY_2>;
 			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
 			wakeup-source;
 		};
 
-		button3 {
+		button-3 {
 			label = "s7";
 			linux,code = <KEY_3>;
 			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;
-- 
2.34.1

Re: [PATCH v2 0/2] Various TQMa6UL/MBa6ULx fixes

[Shawn Guo]

On Wed, Aug 16, 2023 at 09:54:50AM +0200, Alexander Stein wrote:
> Hi,
> this is a follow up to v1 for fixing dtbs_check warnings for TQMa6UL/MBa6ULx.
> While Patch 1 & 3 from v1 have been applied, Patch 2 is inserted into this v2
> again. The patch itself is not changed, because a dependent patch was missing
> in v1. This one has been included in v2.
> 
> Changes in v2:
> * Add a missing dependent patch as new patch 1
> 
> Best regards,
> Alexander
> 
> Alexander Stein (2):
>   ARM: dts: imx6ul: mba6ulx: Mark gpio-buttons as wakeup-source
>   ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

Applied both, thanks!