From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602EF9CA5C; Sun, 24 Sep 2023 18:12:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48C38C433C7; Sun, 24 Sep 2023 18:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695579133; bh=2hiu8uOnsElorfhRSfYCC2/uuUILnH3TV41+hLNifBo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=akB4F2tvtes1qxA4M1M3ZbP3TfZFdRsxCfN9FeMxZ/qHi5W0q1tiwFgitJ4oM89h1 UIpwa1tsGEdpZQoUj+vaAQ8r0miccsqeWjNG19XjgERX+m4ZNut1sWOeIkKr0qG/Lj CqLpZ9IxGyPDVmWM9JeZ1co7eQfBgNBpUj5Rmf9iwl6NUr0ebKCgCxAq66VOTzFqMq 2dzDemBWcGMxvmjnQaV8B1gutABMHGjFZRggFs2o+SZn60aBRqyPPHREHNCVhpZzr2 eIvbgWQ6VwoJ5On4SoJVYL0lDY3ZEqqKdBNh29jQJR8lmTlpqIatx8WFkTKwb5Dlnh UyNIoYpcMyRbQ== Date: Sun, 24 Sep 2023 19:12:04 +0100 From: Jonathan Cameron To: David Lechner Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?UTF-8?B?U8Oh?= , Axel Haslam , Philip Molloy Subject: Re: [PATCH v2 18/19] staging: iio: resolver: ad2s1210: add phase_lock_range attributes Message-ID: <20230924191204.176ee3a6@jic23-huawei> In-Reply-To: <20230921144400.62380-19-dlechner@baylibre.com> References: <20230921144400.62380-1-dlechner@baylibre.com> <20230921144400.62380-19-dlechner@baylibre.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 Sep 2023 09:43:59 -0500 David Lechner wrote: > This adds new phase_lock_range and phase_lock_range_available attributes > to the ad2s1210 resolver driver. These attributes allow the user to set > the phase lock range bit in the control register to modify the behavior > of the resolver to digital converter. > > Signed-off-by: David Lechner The guard() and scoped_guard() magic will work well in here. Otherwise, I think as you raised in the cover letter, that the interface needs some thought as far form obvious what a phase_lock is + nonstandard ABI is best avoided if we can. Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 58 +++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index 71f0913b7e2e..f5b8b290e860 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -259,6 +259,60 @@ static ssize_t excitation_frequency_store(struct device *dev, > return ret; > } > > +static ssize_t phase_lock_range_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); > + int ret; > + > + mutex_lock(&st->lock); > + ret = regmap_test_bits(st->regmap, AD2S1210_REG_CONTROL, > + AD2S1210_PHASE_LOCK_RANGE_44); > + if (ret < 0) > + goto error_ret; > + > + ret = sprintf(buf, "%d\n", ret ? 44 : 360); > + > +error_ret: > + mutex_unlock(&st->lock); > + return ret; > +} > + > +static ssize_t phase_lock_range_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t len) > +{ > + struct ad2s1210_state *st = iio_priv(dev_to_iio_dev(dev)); > + u16 udata; > + int ret; > + > + ret = kstrtou16(buf, 10, &udata); > + if (ret < 0 || (udata != 44 && udata != 360)) > + return -EINVAL; > + > + mutex_lock(&st->lock); > + > + ret = regmap_update_bits(st->regmap, AD2S1210_REG_CONTROL, > + AD2S1210_PHASE_LOCK_RANGE_44, > + udata == 44 ? AD2S1210_PHASE_LOCK_RANGE_44 : 0); > + if (ret < 0) > + goto error_ret; > + > + ret = len; > + > +error_ret: > + mutex_unlock(&st->lock); > + return ret; > +} > + > +static ssize_t phase_lock_range_available_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + return sprintf(buf, "44 360\n"); > +} > + > /* read the fault register since last sample */ > static ssize_t ad2s1210_show_fault(struct device *dev, > struct device_attribute *attr, char *buf) > @@ -506,6 +560,8 @@ static int ad2s1210_write_raw(struct iio_dev *indio_dev, > } > > static IIO_DEVICE_ATTR_RW(excitation_frequency, 0); > +static IIO_DEVICE_ATTR_RW(phase_lock_range, 0); > +static IIO_DEVICE_ATTR_RO(phase_lock_range_available, 0); > static IIO_DEVICE_ATTR(fault, 0644, > ad2s1210_show_fault, ad2s1210_clear_fault, 0); > > @@ -552,6 +608,8 @@ static const struct iio_chan_spec ad2s1210_channels[] = { > > static struct attribute *ad2s1210_attributes[] = { > &iio_dev_attr_excitation_frequency.dev_attr.attr, > + &iio_dev_attr_phase_lock_range.dev_attr.attr, > + &iio_dev_attr_phase_lock_range_available.dev_attr.attr, > &iio_dev_attr_fault.dev_attr.attr, > &iio_dev_attr_los_thrd.dev_attr.attr, > &iio_dev_attr_dos_ovr_thrd.dev_attr.attr,