* [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells
@ 2023-09-09 1:35 Fabio Estevam
2023-09-10 11:29 ` Marco Felsch
2023-09-25 1:58 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-09-09 1:35 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, m.felsch, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
The mac-address is passed as a subnode of the eeprom and its 'reg'
property describe a range of addresses in the eeprom.
Therefore, #size-cells should be set to 1 instead of 0.
This fixes the following schema warnings:
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
index 0b0c95432bdc..0afd90224a59 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
@@ -220,7 +220,7 @@ eeprom@52 {
reg = <0x52>;
pagesize = <16>;
#address-cells = <1>;
- #size-cells = <0>;
+ #size-cells = <1>;
/* MACs stored in ASCII */
ethmac1: mac-address@0 {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells
2023-09-09 1:35 [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells Fabio Estevam
@ 2023-09-10 11:29 ` Marco Felsch
2023-09-25 1:58 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Marco Felsch @ 2023-09-10 11:29 UTC (permalink / raw)
To: Fabio Estevam
Cc: shawnguo, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, Fabio Estevam
Hi Fabio,
thanks for the fix.
On 23-09-08, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The mac-address is passed as a subnode of the eeprom and its 'reg'
> property describe a range of addresses in the eeprom.
>
> Therefore, #size-cells should be set to 1 instead of 0.
>
> This fixes the following schema warnings:
>
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells
2023-09-09 1:35 [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells Fabio Estevam
2023-09-10 11:29 ` Marco Felsch
@ 2023-09-25 1:58 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-09-25 1:58 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-arm-kernel, m.felsch, Fabio Estevam
On Fri, Sep 08, 2023 at 10:35:47PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The mac-address is passed as a subnode of the eeprom and its 'reg'
> property describe a range of addresses in the eeprom.
>
> Therefore, #size-cells should be set to 1 instead of 0.
>
> This fixes the following schema warnings:
>
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
> imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
> from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-25 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-09 1:35 [PATCH] arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells Fabio Estevam
2023-09-10 11:29 ` Marco Felsch
2023-09-25 1:58 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).