From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C194E11C94 for ; Mon, 25 Sep 2023 10:28:57 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9548E; Mon, 25 Sep 2023 03:28:56 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RvJvK2MGYz6D981; Mon, 25 Sep 2023 18:26:37 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 25 Sep 2023 11:28:53 +0100 Date: Mon, 25 Sep 2023 11:28:52 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski CC: Andreas Kemnade , , , , , , , , , , , , , , Subject: Re: [PATCH 1/3] dt-bindings: iio: imu: mpu6050: Add level shifter Message-ID: <20230925112852.00007d34@Huawei.com> In-Reply-To: <6db5b758-2ae6-46fb-a699-d73a2b98b4c2@linaro.org> References: <20230924222559.2038721-1-andreas@kemnade.info> <20230924222559.2038721-2-andreas@kemnade.info> <6db5b758-2ae6-46fb-a699-d73a2b98b4c2@linaro.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, 25 Sep 2023 08:54:08 +0200 Krzysztof Kozlowski wrote: > On 25/09/2023 00:25, Andreas Kemnade wrote: > > Found in ancient platform data struct: > > level_shifter: 0: VLogic, 1: VDD > > > > Signed-off-by: Andreas Kemnade > > --- > > .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > index 1db6952ddca5e..6aae2272fa15c 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > > @@ -48,6 +48,8 @@ properties: > > > > mount-matrix: true > > > > + invensense,level-shifter: true > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > Best regards, > Krzysztof > > Also this one isn't obvious - give it a description in the binding doc. I'm not sure of the arguement for calling it level shift in general. Jonathan