From: Andreas Kemnade <andreas@kemnade.info>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
bcousson@baylibre.com, tony@atomide.com,
jean-baptiste.maneyrol@tdk.com, chenhuiz@axis.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: imu: mpu6050: add level shifter flag
Date: Mon, 25 Sep 2023 14:04:15 +0200 [thread overview]
Message-ID: <20230925140415.00130082@aktux> (raw)
In-Reply-To: <CAHp75VfvmED4ZsmrH4B6m9kGsH=68-zjQd5JMszb6UBTtbF0bw@mail.gmail.com>
On Mon, 25 Sep 2023 14:07:58 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Mon, Sep 25, 2023 at 1:26 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > Some boards fail in magnetometer probe if flag is not set.
>
> Which flag? Can you elaborate a bit more?
>
well see $subj. The level shifter flag.
> Does it deserve the Fixes tag?
>
As there are only certain boards affected, they would also have
to add the flag in dtb, I do not think it deservers a Fixes tag.
Even in the board I have here, there are basically two
mpu9150 connected per cable, only one of them needs the flag.
> ...
>
> > unsigned int val;
> > int ret;
>
> > + ret = regmap_update_bits(st->map, 0x1, 0x80,
> > + st->level_shifter ? 0x80 : 0);
>
> This is a bit cryptic, what does 1 stand for?
>
Well, I do not find anything in
https://invensense.tdk.com/wp-content/uploads/2015/02/MPU-9150-Register-Map.pdf
I have just found a similar line in the ancient 3.0 vendor kernel. No symbolic
names there.
Regards,
Andreas
next prev parent reply other threads:[~2023-09-25 12:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 22:25 [PATCH 0/3] ARM: omap: omap4-embt2ws: Add IMU on control unit Andreas Kemnade
2023-09-24 22:25 ` [PATCH 1/3] dt-bindings: iio: imu: mpu6050: Add level shifter Andreas Kemnade
2023-09-24 23:33 ` Rob Herring
2023-09-24 23:39 ` kernel test robot
2023-09-25 6:54 ` Krzysztof Kozlowski
2023-09-25 10:28 ` Jonathan Cameron
2023-09-25 11:02 ` Andreas Kemnade
2023-09-25 12:24 ` Krzysztof Kozlowski
2023-09-25 13:21 ` Jonathan Cameron
2023-09-25 14:25 ` Jean-Baptiste Maneyrol
2023-09-25 18:02 ` Andreas Kemnade
2023-09-24 22:25 ` [PATCH 2/3] iio: imu: mpu6050: add level shifter flag Andreas Kemnade
2023-09-25 11:07 ` Andy Shevchenko
2023-09-25 11:14 ` Jean-Baptiste Maneyrol
2023-09-25 12:04 ` Andreas Kemnade [this message]
2023-09-25 12:28 ` Andy Shevchenko
2023-09-24 22:25 ` [PATCH 3/3] ARM: dts: omap: omap4-embt2ws: Add IMU at control unit Andreas Kemnade
2023-09-25 6:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925140415.00130082@aktux \
--to=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=bcousson@baylibre.com \
--cc=chenhuiz@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).