public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property
@ 2023-09-25 21:26 Rob Herring
  2023-09-25 21:32 ` Fabio Estevam
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Rob Herring @ 2023-09-25 21:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Liu Ying
  Cc: devicetree, linux-arm-kernel, linux-kernel

A bus schema based on simple-pm-bus shouldn't define how may 'reg' entries
a child device has. That is a property of the device. Drop the 'reg' entry.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml           | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml b/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
index b568d0ce438d..7e1ffc551046 100644
--- a/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
+++ b/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
@@ -73,9 +73,6 @@ patternProperties:
   "^.*@[0-9a-f]+$":
     description: Devices attached to the bus
     type: object
-    properties:
-      reg:
-        maxItems: 1
 
     required:
       - reg
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property
  2023-09-25 21:26 [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property Rob Herring
@ 2023-09-25 21:32 ` Fabio Estevam
  2023-09-26 13:00 ` Conor Dooley
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2023-09-25 21:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, NXP Linux Team, Liu Ying, devicetree,
	linux-arm-kernel, linux-kernel

Hi Rob,

On Mon, Sep 25, 2023 at 6:26 PM Rob Herring <robh@kernel.org> wrote:
>
> A bus schema based on simple-pm-bus shouldn't define how may 'reg' entries

s/may/many

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property
  2023-09-25 21:26 [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property Rob Herring
  2023-09-25 21:32 ` Fabio Estevam
@ 2023-09-26 13:00 ` Conor Dooley
  2023-09-27  2:06 ` Ying Liu
  2023-10-06 18:52 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-09-26 13:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Liu Ying,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

On Mon, Sep 25, 2023 at 04:26:34PM -0500, Rob Herring wrote:
> A bus schema based on simple-pm-bus shouldn't define how may 'reg' entries
> a child device has. That is a property of the device. Drop the 'reg' entry.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  .../bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml           | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml b/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
> index b568d0ce438d..7e1ffc551046 100644
> --- a/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
> +++ b/Documentation/devicetree/bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml
> @@ -73,9 +73,6 @@ patternProperties:
>    "^.*@[0-9a-f]+$":
>      description: Devices attached to the bus
>      type: object
> -    properties:
> -      reg:
> -        maxItems: 1
>  
>      required:
>        - reg
> -- 
> 2.40.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property
  2023-09-25 21:26 [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property Rob Herring
  2023-09-25 21:32 ` Fabio Estevam
  2023-09-26 13:00 ` Conor Dooley
@ 2023-09-27  2:06 ` Ying Liu
  2023-10-06 18:52 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Ying Liu @ 2023-09-27  2:06 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	dl-linux-imx
  Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

On Tuesday, September 26, 2023 5:27 AM, Rob Herring <robh@kernel.org> wrote:
> A bus schema based on simple-pm-bus shouldn't define how may 'reg'
> entries
> a child device has. That is a property of the device. Drop the 'reg' entry.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml           | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Liu Ying <victor.liu@nxp.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property
  2023-09-25 21:26 [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property Rob Herring
                   ` (2 preceding siblings ...)
  2023-09-27  2:06 ` Ying Liu
@ 2023-10-06 18:52 ` Rob Herring
  3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-10-06 18:52 UTC (permalink / raw)
  To: Rob Herring
  Cc: Conor Dooley, Liu Ying, NXP Linux Team, Shawn Guo,
	linux-arm-kernel, Sascha Hauer, Krzysztof Kozlowski,
	Pengutronix Kernel Team, devicetree, linux-kernel, Fabio Estevam


On Mon, 25 Sep 2023 16:26:34 -0500, Rob Herring wrote:
> A bus schema based on simple-pm-bus shouldn't define how may 'reg' entries
> a child device has. That is a property of the device. Drop the 'reg' entry.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/bus/fsl,imx8qxp-pixel-link-msi-bus.yaml           | 3 ---
>  1 file changed, 3 deletions(-)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-10-06 18:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 21:26 [PATCH] dt-bindings: bus: fsl,imx8qxp-pixel-link-msi-bus: Drop child 'reg' property Rob Herring
2023-09-25 21:32 ` Fabio Estevam
2023-09-26 13:00 ` Conor Dooley
2023-09-27  2:06 ` Ying Liu
2023-10-06 18:52 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox