* Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas
2023-09-25 22:09 [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas Rob Herring
@ 2023-09-26 6:16 ` Herve Codina
2023-09-26 13:06 ` Conor Dooley
2023-09-26 15:07 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Herve Codina @ 2023-09-26 6:16 UTC (permalink / raw)
To: Rob Herring
Cc: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Shenghao Ding, Kevin Lu, Baojun Xu, David Rau, Damien Horsley,
Geert Uytterhoeven, Kuninori Morimoto, alsa-devel, devicetree,
linux-kernel, linuxppc-dev
On Mon, 25 Sep 2023 17:09:28 -0500
Rob Herring <robh@kernel.org> wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties or additionalProperties as appropriate.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 1 +
> Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml | 1 +
> Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> index eb7d219e2c86..19137abdba3e 100644
> --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> @@ -89,6 +89,7 @@ properties:
>
> da7219_aad:
> type: object
> + additionalProperties: false
> description:
> Configuration of advanced accessory detection.
> properties:
> diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> index ff5cd9241941..b522ed7dcc51 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> @@ -33,6 +33,7 @@ patternProperties:
> description:
> A DAI managed by this controller
> type: object
> + additionalProperties: false
>
> properties:
> reg:
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> index b6a4360ab845..0b4f003989a4 100644
> --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> @@ -60,6 +60,7 @@ properties:
>
> ports:
> $ref: audio-graph-port.yaml#/definitions/port-base
> + unevaluatedProperties: false
> properties:
> port@0:
> $ref: audio-graph-port.yaml#
At least for sound/fsl,qmc-audio.yaml:
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas
2023-09-25 22:09 [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas Rob Herring
2023-09-26 6:16 ` Herve Codina
@ 2023-09-26 13:06 ` Conor Dooley
2023-09-26 15:07 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-09-26 13:06 UTC (permalink / raw)
To: Rob Herring
Cc: Liam Girdwood, Mark Brown, Krzysztof Kozlowski, Conor Dooley,
Herve Codina, Shenghao Ding, Kevin Lu, Baojun Xu, David Rau,
Damien Horsley, Geert Uytterhoeven, Kuninori Morimoto, alsa-devel,
devicetree, linux-kernel, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]
On Mon, Sep 25, 2023 at 05:09:28PM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties or additionalProperties as appropriate.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 1 +
> Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml | 1 +
> Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> index eb7d219e2c86..19137abdba3e 100644
> --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> @@ -89,6 +89,7 @@ properties:
>
> da7219_aad:
> type: object
> + additionalProperties: false
> description:
> Configuration of advanced accessory detection.
> properties:
> diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> index ff5cd9241941..b522ed7dcc51 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml
> @@ -33,6 +33,7 @@ patternProperties:
> description:
> A DAI managed by this controller
> type: object
> + additionalProperties: false
>
> properties:
> reg:
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> index b6a4360ab845..0b4f003989a4 100644
> --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> @@ -60,6 +60,7 @@ properties:
>
> ports:
> $ref: audio-graph-port.yaml#/definitions/port-base
> + unevaluatedProperties: false
> properties:
> port@0:
> $ref: audio-graph-port.yaml#
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas
2023-09-25 22:09 [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas Rob Herring
2023-09-26 6:16 ` Herve Codina
2023-09-26 13:06 ` Conor Dooley
@ 2023-09-26 15:07 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2023-09-26 15:07 UTC (permalink / raw)
To: Liam Girdwood, Krzysztof Kozlowski, Conor Dooley, Herve Codina,
Shenghao Ding, Kevin Lu, Baojun Xu, David Rau, Damien Horsley,
Geert Uytterhoeven, Kuninori Morimoto, Rob Herring
Cc: alsa-devel, devicetree, linux-kernel, linuxppc-dev
On Mon, 25 Sep 2023 17:09:28 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties or additionalProperties as appropriate.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas
commit: 7b71da59122c3ab82908910abf78db1fd6340cac
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread