From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 935E112B73 for ; Tue, 26 Sep 2023 09:18:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74BF3C433C8; Tue, 26 Sep 2023 09:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695719922; bh=mlwG5wTGIlk+oeIJXV5mNozKoyrhncfuc0jgKxRBWzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T3S8kaOmXQ8FsN5083g0llW5eIovcu9kopK2DSymPv33VasNg76uU6RDfujD2zvMT lsYnOPIJ2K4xO6Dh2QDaq3lOjo61mnEaDVPIimXMb/AEvkuKO2OYRgOm5HcsibrY98 UELjcG8tDoHEyeTaQ/bvyX4QqAXbVoP+9y08QqgshIfDlTDS1Dh0EMN+644cBjxO9o SPBQlKkRrN50VO8Hw3hLdufDe1Up9Q1INpDIVH9l1bVDRFarfu1GgVi34TBQcIhxTz nb0SlbqbMrfGna9Mk03r/CBR9DhOMTTYc45FrongNwTNiXYWiK6paesvAtetzzKE/i JjAQsgM+1C8eg== Date: Tue, 26 Sep 2023 10:18:37 +0100 From: Conor Dooley To: Jon Hunter Cc: Rob Herring , Jean Delvare , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, Ninad Malwade , Thierry Reding , Nicolin Chen Subject: Re: [PATCH V3 1/4] dt-bindings: hwmon: ina3221: Convert to json-schema Message-ID: <20230926-caretaker-raging-0fe380cd1232@spud> References: <20230921130818.21247-1-jonathanh@nvidia.com> <20230921130818.21247-2-jonathanh@nvidia.com> <20230922210101.GA3562325-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t5SaNNLRZ2Jhwil1" Content-Disposition: inline In-Reply-To: --t5SaNNLRZ2Jhwil1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 25, 2023 at 11:46:58AM +0100, Jon Hunter wrote: >=20 >=20 > On 22/09/2023 22:01, Rob Herring wrote: > > On Thu, Sep 21, 2023 at 02:08:15PM +0100, Jon Hunter wrote: > > > From: Ninad Malwade > > >=20 > > > Convert the TI INA3221 bindings from the free-form text format to > > > json-schema. > > >=20 > > > Note that the INA3221 input channels default to enabled in the chip. > > > Unless channels are explicitly disabled in device-tree, input > > > channels will be enabled. > > >=20 > > > Signed-off-by: Thierry Reding > > > Signed-off-by: Ninad Malwade > > > Signed-off-by: Jon Hunter > > > --- > > > .../devicetree/bindings/hwmon/ina3221.txt | 54 ---------- > > > .../devicetree/bindings/hwmon/ti,ina3221.yaml | 98 ++++++++++++++++= +++ > > > 2 files changed, 98 insertions(+), 54 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.= txt > > > create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina32= 21.yaml >=20 >=20 > ... >=20 > > > +examples: > > > + - | > > > + i2c { > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + power-sensor@40 { > > > + compatible =3D "ti,ina3221"; > > > + reg =3D <0x40>; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + input@0 { > > > + reg =3D <0x0>; > > > + status =3D "disabled"; > >=20 > > Examples should be enabled. >=20 >=20 > Yes normally that would be the case. However, per the discussion with > Guenter and the comment in the changelog, for this device channels are > enabled in the chip by default. And so to disable them, we need to > explicitly disable in device-tree. Maybe a comment at this location would be good then, to point out that this is what you are trying to demonstrate with this example? --t5SaNNLRZ2Jhwil1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRKh7QAKCRB4tDGHoIJi 0p6zAP9IDPIlYXKh1b6yTrS2dz8pjd5jzbbeXViPKKFPs5v8FgD/W5j59c0Z9HxS NecwcJZBhTXgt/Ro2/fPA2mvhz1agws= =NJQ8 -----END PGP SIGNATURE----- --t5SaNNLRZ2Jhwil1--