From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 085DE28E17 for ; Tue, 26 Sep 2023 13:25:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D57EDC433C8; Tue, 26 Sep 2023 13:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695734751; bh=Ad5HUhPEQj40kGgmNxNGQfjNC2SztcpqDvyMP2qHtaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e+UEasE7mJB5wVg49Yb7RoUWryT/uylyMtAIlEBr/Q7wavS9BKub+GBa+bzvXWfYm 1hCu1ptxSPAIFwybbWRUjMNEUokd9C6QeBSYIzgtmZJq/PsYxnid57yCjR0jY87b0j qcR8MQ2yoFmWdSKLhtsHiZyNVIS+HVOr6+0ZZLIlOvDKwaRy36nEio3Gil47bRhwuu oSP0nlsIlyr9E+EX7OOdAZO+yNbQnAtjiSuazJDlNl+wgSNb68Uyz7HcE8KdOD+E/0 xObc2w+mcved+DxIOu8goWySwQb6svG4YLgTPxS9AUVd09UA+XBPiWYl2sc1cmfbo7 tFY/36EwU8V+A== Date: Tue, 26 Sep 2023 14:25:45 +0100 From: Conor Dooley To: Ming Qian Cc: mirela.rabulea@oss.nxp.com, robh+dt@kernel.org, shawnguo@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder Message-ID: <20230926-slackness-target-b74e33ab1031@spud> References: <20230926101000.13392-1-ming.qian@nxp.com> <20230926101000.13392-2-ming.qian@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7eY7R+Myp0ZzWp6O" Content-Disposition: inline In-Reply-To: <20230926101000.13392-2-ming.qian@nxp.com> --7eY7R+Myp0ZzWp6O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 26, 2023 at 06:10:00PM +0800, Ming Qian wrote: > There are total 4 slots available in the IP, and we only need to use one > slot in one os, assign a single slot, configure interrupt and power > domain only for 1 slot, not for the all 4 slots. >=20 > Signed-off-by: Ming Qian > --- > v4 > - improve commit message > - don't make an ABI break What does this mean? Can you please try to explain things a bit more clearly in your changelogs? Also, where is the code that actually makes use of these properties? > v3 > - add vender prefix, change property slot to nxp,slot > - add type for property slot >=20 > .../bindings/media/nxp,imx8-jpeg.yaml | 45 +++++++++---------- > 1 file changed, 21 insertions(+), 24 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b= /Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..4bcfc815c894 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -32,19 +32,26 @@ properties: > maxItems: 1 > =20 > interrupts: > - description: | > - There are 4 slots available in the IP, which the driver may use > - If a certain slot is used, it should have an associated interrupt > - The interrupt with index i is assumed to be for slot i > - minItems: 1 # At least one slot is needed by the driver > - maxItems: 4 # The IP has 4 slots available for use > + description: > + Interrupt number for slot > + maxItems: 1 So, what happens to users that already exist that have 2, 3 or 4 interrupts? Your commit message says: > There are total 4 slots available in the IP, and we only need to use one > slot in one os, assign a single slot, configure interrupt and power > domain only for 1 slot, not for the all 4 slots. Note that "only need to use one" doesn't mean that a user might not want to use more than one. Is it possible to use more than one slot? Also, if the interrupt numbers map 1:1 to slots, as the previous binding states, why do you even need this new "nxp,slot" property? Thanks, Conor. > =20 > power-domains: > description: > List of phandle and PM domain specifier as documented in > Documentation/devicetree/bindings/power/power_domain.txt > - minItems: 2 # Wrapper and 1 slot > - maxItems: 5 # Wrapper and 4 slots > + minItems: 1 # VPUMIX > + maxItems: 2 # Wrapper and 1 slot > + > + nxp,slot: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Integer number of slot index used. There are 4 slots available in = the IP, > + and driver can use a certain slot, it should have an associated in= terrupt > + and power-domain. In theory, it supports 4 os or vm. If not specif= ied, 0 > + is used by default. > + minimum: 0 > + maximum: 3 > =20 > required: > - compatible > @@ -62,28 +69,18 @@ examples: > jpegdec: jpegdec@58400000 { > compatible =3D "nxp,imx8qxp-jpgdec"; > reg =3D <0x58400000 0x00050000 >; > - interrupts =3D , > - , > - , > - ; > + interrupts =3D ; > power-domains =3D <&pd IMX_SC_R_MJPEG_DEC_MP>, > - <&pd IMX_SC_R_MJPEG_DEC_S0>, > - <&pd IMX_SC_R_MJPEG_DEC_S1>, > - <&pd IMX_SC_R_MJPEG_DEC_S2>, > - <&pd IMX_SC_R_MJPEG_DEC_S3>; > + <&pd IMX_SC_R_MJPEG_DEC_S0>; > + nxp,slot =3D <0>; > }; > =20 > jpegenc: jpegenc@58450000 { > compatible =3D "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; > reg =3D <0x58450000 0x00050000 >; > - interrupts =3D , > - , > - , > - ; > + interrupts =3D ; > power-domains =3D <&pd IMX_SC_R_MJPEG_ENC_MP>, > - <&pd IMX_SC_R_MJPEG_ENC_S0>, > - <&pd IMX_SC_R_MJPEG_ENC_S1>, > - <&pd IMX_SC_R_MJPEG_ENC_S2>, > - <&pd IMX_SC_R_MJPEG_ENC_S3>; > + <&pd IMX_SC_R_MJPEG_ENC_S0>; > + nxp,slot =3D <0>; > }; > ... > --=20 > 2.38.1 >=20 --7eY7R+Myp0ZzWp6O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRLb2QAKCRB4tDGHoIJi 0rLVAP490xhNnzsc7JCNkZo8y8ijcSPOgsQTTnBa/itMeZP5VQEA9H77egyoeeCt VfvJ/btIc+SD/849pirq+9fKnia3Dw4= =VyRg -----END PGP SIGNATURE----- --7eY7R+Myp0ZzWp6O--