devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,  David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	 cros-qcom-dts-watchers@chromium.org,
	Andy Gross <agross@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	 Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 Luca Weiss <luca.weiss@fairphone.com>,
	Rob Clark <robdclark@chromium.org>,
	 linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH 1/7] drm/msm/a6xx: Fix unknown speedbin case
Date: Tue, 26 Sep 2023 20:24:36 +0200	[thread overview]
Message-ID: <20230926-topic-a643-v1-1-7af6937ac0a3@linaro.org> (raw)
In-Reply-To: <20230926-topic-a643-v1-0-7af6937ac0a3@linaro.org>

When opp-supported-hw is present under an OPP node, but no form of
opp_set_supported_hw() has been called, that OPP is ignored by the API
and marked as unsupported.

Before Commit c928a05e4415 ("drm/msm/adreno: Move speedbin mapping to
device table"), an unknown speedbin would result in marking all OPPs
as available, but it's better to avoid potentially overclocking the
silicon - the GMU will simply refuse to power up the chip.

Currently, the Adreno speedbin code does just that (AND returns an
invalid error, (int)UINT_MAX). Fix that by defaulting to speedbin 0
(which is conveniently always bound to fuseval == 0).

Fixes: c928a05e4415 ("drm/msm/adreno: Move speedbin mapping to device table")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index d4e85e24002f..522ca7fe6762 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -2237,7 +2237,7 @@ static int a6xx_set_supported_hw(struct device *dev, const struct adreno_info *i
 		DRM_DEV_ERROR(dev,
 			"missing support for speed-bin: %u. Some OPPs may not be supported by hardware\n",
 			speedbin);
-		return UINT_MAX;
+		supp_hw = BIT(0); /* Default */
 	}
 
 	ret = devm_pm_opp_set_supported_hw(dev, &supp_hw, 1);

-- 
2.42.0


  reply	other threads:[~2023-09-26 18:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 18:24 [PATCH 0/7] Adreno 643 + fixes Konrad Dybcio
2023-09-26 18:24 ` Konrad Dybcio [this message]
2023-10-16 19:52   ` [PATCH 1/7] drm/msm/a6xx: Fix unknown speedbin case Akhil P Oommen
2023-10-17 19:42     ` [Freedreno] " Akhil P Oommen
2023-09-26 18:24 ` [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635 Konrad Dybcio
2023-10-16 20:11   ` Akhil P Oommen
2023-10-17  7:33     ` Rob Clark
2023-10-17 15:41       ` Konrad Dybcio
2023-10-17 19:21       ` Akhil P Oommen
2023-09-26 18:24 ` [PATCH 3/7] drm/msm/adreno: Add A635 speedbin 0xac (A643) Konrad Dybcio
2023-09-26 18:24 ` [PATCH 4/7] arm64: dts: qcom: sc7280: Add ZAP shader support Konrad Dybcio
2023-09-26 18:27   ` Konrad Dybcio
2023-09-26 18:24 ` [PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs Konrad Dybcio
2023-10-16 20:22   ` Akhil P Oommen
2023-10-18 20:20     ` Konrad Dybcio
2023-09-26 18:24 ` [PATCH 6/7] arm64: dts: qcom: sc7280: Mark Adreno SMMU as DMA coherent Konrad Dybcio
2023-09-26 18:26   ` Konrad Dybcio
2023-10-16 20:23   ` [Freedreno] " Akhil P Oommen
2023-09-26 18:24 ` [PATCH 7/7] arm64: dts: qcom: sc7280: Add 0xac Adreno speed bin Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926-topic-a643-v1-1-7af6937ac0a3@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_akhilpo@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).