devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,  David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	 cros-qcom-dts-watchers@chromium.org,
	Andy Gross <agross@kernel.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	 Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 Luca Weiss <luca.weiss@fairphone.com>,
	Rob Clark <robdclark@chromium.org>,
	 linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs
Date: Tue, 26 Sep 2023 20:24:40 +0200	[thread overview]
Message-ID: <20230926-topic-a643-v1-5-7af6937ac0a3@linaro.org> (raw)
In-Reply-To: <20230926-topic-a643-v1-0-7af6937ac0a3@linaro.org>

GPU_SMMU SID 1 is meant for Adreno LPAC (Low Priority Async Compute).
On platforms that support it (in firmware), it is necessary to
describe that link, or Adreno register access will hang the board.

Add that and fix up the SMR mask of SID 0, which seems to have been
copypasted from another SoC.

Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index c38ddf267ef5..0d96d1454c49 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2603,7 +2603,8 @@ gpu: gpu@3d00000 {
 				    "cx_mem",
 				    "cx_dbgc";
 			interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
-			iommus = <&adreno_smmu 0 0x401>;
+			iommus = <&adreno_smmu 0 0x400>,
+				 <&adreno_smmu 1 0x400>;
 			operating-points-v2 = <&gpu_opp_table>;
 			qcom,gmu = <&gmu>;
 			interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;

-- 
2.42.0


  parent reply	other threads:[~2023-09-26 18:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 18:24 [PATCH 0/7] Adreno 643 + fixes Konrad Dybcio
2023-09-26 18:24 ` [PATCH 1/7] drm/msm/a6xx: Fix unknown speedbin case Konrad Dybcio
2023-10-16 19:52   ` Akhil P Oommen
2023-10-17 19:42     ` [Freedreno] " Akhil P Oommen
2023-09-26 18:24 ` [PATCH 2/7] drm/msm/adreno: Add ZAP firmware name to A635 Konrad Dybcio
2023-10-16 20:11   ` Akhil P Oommen
2023-10-17  7:33     ` Rob Clark
2023-10-17 15:41       ` Konrad Dybcio
2023-10-17 19:21       ` Akhil P Oommen
2023-09-26 18:24 ` [PATCH 3/7] drm/msm/adreno: Add A635 speedbin 0xac (A643) Konrad Dybcio
2023-09-26 18:24 ` [PATCH 4/7] arm64: dts: qcom: sc7280: Add ZAP shader support Konrad Dybcio
2023-09-26 18:27   ` Konrad Dybcio
2023-09-26 18:24 ` Konrad Dybcio [this message]
2023-10-16 20:22   ` [PATCH 5/7] arm64: dts: qcom: sc7280: Fix up GPU SIDs Akhil P Oommen
2023-10-18 20:20     ` Konrad Dybcio
2023-09-26 18:24 ` [PATCH 6/7] arm64: dts: qcom: sc7280: Mark Adreno SMMU as DMA coherent Konrad Dybcio
2023-09-26 18:26   ` Konrad Dybcio
2023-10-16 20:23   ` [Freedreno] " Akhil P Oommen
2023-09-26 18:24 ` [PATCH 7/7] arm64: dts: qcom: sc7280: Add 0xac Adreno speed bin Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926-topic-a643-v1-5-7af6937ac0a3@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_akhilpo@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).