devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: omap4: embt2ws: add LED
@ 2023-08-19 14:31 Andreas Kemnade
  2023-09-26  7:19 ` Tony Lindgren
  2023-10-31  9:16 ` Pavel Machek
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Kemnade @ 2023-08-19 14:31 UTC (permalink / raw)
  To: bcousson, tony, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	linux-omap, devicetree, linux-kernel
  Cc: Andreas Kemnade

Add LED since the driver is now available.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 .../boot/dts/ti/omap/omap4-epson-embt2ws.dts  | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index e119e2cccc4e1..f47d330fb6ee4 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -4,6 +4,7 @@
  */
 /dts-v1/;
 
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/input/input.h>
 #include "omap4460.dtsi"
 
@@ -206,7 +207,31 @@ &i2c3 {
 
 	clock-frequency = <100000>;
 
-	/* TODO: BD2606MVV at 0x66 */
+	led-controller@66 {
+		compatible = "rohm,bd2606mvv";
+		reg = <0x66>;
+
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			color = <LED_COLOR_ID_GREEN>;
+			function = LED_FUNCTION_STATUS;
+		};
+
+		led@2 {
+			reg = <2>;
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_STATUS;
+		};
+
+		led@4 {
+			reg = <4>;
+			color = <LED_COLOR_ID_RED>;
+			function = LED_FUNCTION_STATUS;
+		};
+	};
 };
 
 &i2c4 {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: omap4: embt2ws: add LED
  2023-08-19 14:31 [PATCH] ARM: dts: omap4: embt2ws: add LED Andreas Kemnade
@ 2023-09-26  7:19 ` Tony Lindgren
  2023-10-31  9:16 ` Pavel Machek
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2023-09-26  7:19 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: bcousson, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-omap,
	devicetree, linux-kernel

* Andreas Kemnade <andreas@kemnade.info> [230819 17:31]:
> Add LED since the driver is now available.

Thanks applying into omap-for-v6.7/dt.

Tony

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: omap4: embt2ws: add LED
  2023-08-19 14:31 [PATCH] ARM: dts: omap4: embt2ws: add LED Andreas Kemnade
  2023-09-26  7:19 ` Tony Lindgren
@ 2023-10-31  9:16 ` Pavel Machek
  1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2023-10-31  9:16 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: bcousson, tony, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	linux-omap, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Hi!

> Add LED since the driver is now available.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Is it one LED or three LEDs?

If it is one, we should use multicolor...

BR,
										Pavel
										
> @@ -206,7 +207,31 @@ &i2c3 {
>  
>  	clock-frequency = <100000>;
>  
> -	/* TODO: BD2606MVV at 0x66 */
> +	led-controller@66 {
> +		compatible = "rohm,bd2606mvv";
> +		reg = <0x66>;
> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@0 {
> +			reg = <0>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@2 {
> +			reg = <2>;
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +
> +		led@4 {
> +			reg = <4>;
> +			color = <LED_COLOR_ID_RED>;
> +			function = LED_FUNCTION_STATUS;
> +		};
> +	};
>  };
>  
>  &i2c4 {

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-31  9:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-19 14:31 [PATCH] ARM: dts: omap4: embt2ws: add LED Andreas Kemnade
2023-09-26  7:19 ` Tony Lindgren
2023-10-31  9:16 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).