From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DFED4A32 for ; Tue, 26 Sep 2023 06:16:15 +0000 (UTC) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34553B8; Mon, 25 Sep 2023 23:16:13 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id E4C8640002; Tue, 26 Sep 2023 06:16:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1695708971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ujWjVGuy4dT6unLLLWziSi5PLKzhpynPY9RTZBnxGwk=; b=oIGO8IF31DJJA2EGozaZKK2wlXz/swohWFBat1HvAudglHQA4x4gfzgF7oXHYynuEAs6CO mqUgtgucAH1exMSSkAv+EOEZ0c4NeVfOZlWIF3szEJo+9aMT119c2CPmaoMih9J8hX7EJp 2Pkg/zP427YLxkl6b4D2Nis7/eUV19HIimsagGaiCyrIeamOiYc+eNrC79Kqb5VqGuDae7 qkbb8UUbxndHfgymj9uehhZfmfyj/BKkC+W5XMWkwNIZzo8SONYG4Oqq/XKQZ+nbp5yufC 6vwKYX7BJulSOKEVgUXo8elNA23T8SeF1cnERnAlK1ZueLL/5puINDuXzlxgYg== Date: Tue, 26 Sep 2023 08:16:08 +0200 From: Herve Codina To: Rob Herring Cc: Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Shenghao Ding , Kevin Lu , Baojun Xu , David Rau , Damien Horsley , Geert Uytterhoeven , Kuninori Morimoto , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas Message-ID: <20230926081608.2eea3919@bootlin.com> In-Reply-To: <20230925220947.2031536-1-robh@kernel.org> References: <20230925220947.2031536-1-robh@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, 25 Sep 2023 17:09:28 -0500 Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Add unevaluatedProperties or additionalProperties as appropriate. > > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 1 + > Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml | 1 + > Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > index eb7d219e2c86..19137abdba3e 100644 > --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml > @@ -89,6 +89,7 @@ properties: > > da7219_aad: > type: object > + additionalProperties: false > description: > Configuration of advanced accessory detection. > properties: > diff --git a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > index ff5cd9241941..b522ed7dcc51 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,qmc-audio.yaml > @@ -33,6 +33,7 @@ patternProperties: > description: > A DAI managed by this controller > type: object > + additionalProperties: false > > properties: > reg: > diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml > index b6a4360ab845..0b4f003989a4 100644 > --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml > +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml > @@ -60,6 +60,7 @@ properties: > > ports: > $ref: audio-graph-port.yaml#/definitions/port-base > + unevaluatedProperties: false > properties: > port@0: > $ref: audio-graph-port.yaml# At least for sound/fsl,qmc-audio.yaml: Acked-by: Herve Codina Best regards, Hervé