From: Ming Qian <ming.qian@nxp.com>
To: mirela.rabulea@oss.nxp.com, robh+dt@kernel.org, shawnguo@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com,
tao.jiang_2@nxp.com, linux-imx@nxp.com,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] dt-bindings: media: imx-jpeg: Assign slot for imx jpeg encoder/decoder
Date: Tue, 26 Sep 2023 18:10:00 +0800 [thread overview]
Message-ID: <20230926101000.13392-2-ming.qian@nxp.com> (raw)
In-Reply-To: <20230926101000.13392-1-ming.qian@nxp.com>
There are total 4 slots available in the IP, and we only need to use one
slot in one os, assign a single slot, configure interrupt and power
domain only for 1 slot, not for the all 4 slots.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
v4
- improve commit message
- don't make an ABI break
v3
- add vender prefix, change property slot to nxp,slot
- add type for property slot
.../bindings/media/nxp,imx8-jpeg.yaml | 45 +++++++++----------
1 file changed, 21 insertions(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
index 3d9d1db37040..4bcfc815c894 100644
--- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
+++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml
@@ -32,19 +32,26 @@ properties:
maxItems: 1
interrupts:
- description: |
- There are 4 slots available in the IP, which the driver may use
- If a certain slot is used, it should have an associated interrupt
- The interrupt with index i is assumed to be for slot i
- minItems: 1 # At least one slot is needed by the driver
- maxItems: 4 # The IP has 4 slots available for use
+ description:
+ Interrupt number for slot
+ maxItems: 1
power-domains:
description:
List of phandle and PM domain specifier as documented in
Documentation/devicetree/bindings/power/power_domain.txt
- minItems: 2 # Wrapper and 1 slot
- maxItems: 5 # Wrapper and 4 slots
+ minItems: 1 # VPUMIX
+ maxItems: 2 # Wrapper and 1 slot
+
+ nxp,slot:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Integer number of slot index used. There are 4 slots available in the IP,
+ and driver can use a certain slot, it should have an associated interrupt
+ and power-domain. In theory, it supports 4 os or vm. If not specified, 0
+ is used by default.
+ minimum: 0
+ maximum: 3
required:
- compatible
@@ -62,28 +69,18 @@ examples:
jpegdec: jpegdec@58400000 {
compatible = "nxp,imx8qxp-jpgdec";
reg = <0x58400000 0x00050000 >;
- interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
- <&pd IMX_SC_R_MJPEG_DEC_S0>,
- <&pd IMX_SC_R_MJPEG_DEC_S1>,
- <&pd IMX_SC_R_MJPEG_DEC_S2>,
- <&pd IMX_SC_R_MJPEG_DEC_S3>;
+ <&pd IMX_SC_R_MJPEG_DEC_S0>;
+ nxp,slot = <0>;
};
jpegenc: jpegenc@58450000 {
compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc";
reg = <0x58450000 0x00050000 >;
- interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
- <&pd IMX_SC_R_MJPEG_ENC_S0>,
- <&pd IMX_SC_R_MJPEG_ENC_S1>,
- <&pd IMX_SC_R_MJPEG_ENC_S2>,
- <&pd IMX_SC_R_MJPEG_ENC_S3>;
+ <&pd IMX_SC_R_MJPEG_ENC_S0>;
+ nxp,slot = <0>;
};
...
--
2.38.1
next prev parent reply other threads:[~2023-09-26 10:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 10:09 [PATCH v4 1/2] arm64: dts: imx8-ss-img: Assign slot for imx jpeg encoder/decoder Ming Qian
2023-09-26 10:10 ` Ming Qian [this message]
2023-09-26 13:25 ` [PATCH v4 2/2] dt-bindings: media: imx-jpeg: " Conor Dooley
2023-09-27 2:10 ` [EXT] " Ming Qian
2023-09-27 8:10 ` Krzysztof Kozlowski
2023-09-27 9:11 ` Conor Dooley
2023-09-27 9:25 ` Ming Qian
2023-09-28 5:24 ` Krzysztof Kozlowski
2023-09-28 10:03 ` Ming Qian
2023-09-27 8:06 ` Krzysztof Kozlowski
2023-09-27 9:10 ` [EXT] " Ming Qian
2023-09-28 5:06 ` Krzysztof Kozlowski
2023-09-28 9:42 ` Ming Qian
2023-09-30 14:40 ` Krzysztof Kozlowski
2023-10-02 1:23 ` Ming Qian
2023-09-28 5:06 ` Krzysztof Kozlowski
2023-09-28 16:47 ` Rob Herring
2023-09-29 2:03 ` Ming Qian
2023-09-27 8:10 ` [PATCH v4 1/2] arm64: dts: imx8-ss-img: " Krzysztof Kozlowski
2023-09-27 9:19 ` [EXT] " Ming Qian
2023-09-28 5:02 ` Krzysztof Kozlowski
2023-09-28 9:51 ` Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926101000.13392-2-ming.qian@nxp.com \
--to=ming.qian@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eagle.zhou@nxp.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@oss.nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tao.jiang_2@nxp.com \
--cc=xiahong.bao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).