* [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas
@ 2023-09-26 16:44 Rob Herring
2023-09-27 15:13 ` Conor Dooley
2023-09-30 20:28 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-09-26 16:44 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley
Cc: linux-pm, devicetree, linux-kernel
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Add unevaluatedProperties as needed, and then add any missing properties
flagged by the addition.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/power/supply/sbs,sbs-manager.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
index f255f3858d08..2e21846463ba 100644
--- a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
+++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
@@ -47,6 +47,12 @@ patternProperties:
"^i2c@[1-4]$":
type: object
$ref: /schemas/i2c/i2c-controller.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ reg:
+ minimum: 1
+ maximum: 4
examples:
- |
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas
2023-09-26 16:44 [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas Rob Herring
@ 2023-09-27 15:13 ` Conor Dooley
2023-09-30 20:28 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-09-27 15:13 UTC (permalink / raw)
To: Rob Herring
Cc: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley, linux-pm,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
On Tue, Sep 26, 2023 at 11:44:42AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties as needed, and then add any missing properties
> flagged by the addition.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> .../devicetree/bindings/power/supply/sbs,sbs-manager.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> index f255f3858d08..2e21846463ba 100644
> --- a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.yaml
> @@ -47,6 +47,12 @@ patternProperties:
> "^i2c@[1-4]$":
> type: object
> $ref: /schemas/i2c/i2c-controller.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + minimum: 1
> + maximum: 4
>
> examples:
> - |
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas
2023-09-26 16:44 [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas Rob Herring
2023-09-27 15:13 ` Conor Dooley
@ 2023-09-30 20:28 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-09-30 20:28 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley, Rob Herring
Cc: linux-pm, devicetree, linux-kernel
On Tue, 26 Sep 2023 11:44:42 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Add unevaluatedProperties as needed, and then add any missing properties
> flagged by the addition.
>
> [...]
Applied, thanks!
[1/1] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas
commit: 15a4e422f3c9b041261b6810c90ce09d4ebe2a14
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-30 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 16:44 [PATCH] dt-bindings: power/supply: sbs-manager: Add missing unevaluatedProperties on child node schemas Rob Herring
2023-09-27 15:13 ` Conor Dooley
2023-09-30 20:28 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).