* [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
@ 2023-09-26 16:45 Rob Herring
2023-09-27 15:11 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2023-09-26 16:45 UTC (permalink / raw)
To: Rafał Miłecki, Srinivas Kandagatla, Krzysztof Kozlowski,
Conor Dooley
Cc: devicetree, linux-kernel
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
index 36d97fb87865..9c36afc7084b 100644
--- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
+++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
@@ -51,6 +51,8 @@ properties:
ethaddr:
type: object
description: Ethernet interfaces base MAC address.
+ additionalProperties: false
+
properties:
"#nvmem-cell-cells":
description: The first argument is a MAC address offset.
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
2023-09-26 16:45 [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas Rob Herring
@ 2023-09-27 15:11 ` Conor Dooley
2023-09-28 10:43 ` Rafał Miłecki
2023-10-07 10:23 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2023-09-27 15:11 UTC (permalink / raw)
To: Rob Herring
Cc: Rafał Miłecki, Srinivas Kandagatla, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Tue, Sep 26, 2023 at 11:45:25AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
2023-09-26 16:45 [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas Rob Herring
2023-09-27 15:11 ` Conor Dooley
@ 2023-09-28 10:43 ` Rafał Miłecki
2023-10-07 10:23 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Rafał Miłecki @ 2023-09-28 10:43 UTC (permalink / raw)
To: Rob Herring
Cc: Srinivas Kandagatla, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-kernel
On 2023-09-26 18:45, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks!
Acked-by: Rafał Miłecki <rafal@milecki.pl>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
2023-09-26 16:45 [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas Rob Herring
2023-09-27 15:11 ` Conor Dooley
2023-09-28 10:43 ` Rafał Miłecki
@ 2023-10-07 10:23 ` Srinivas Kandagatla
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2023-10-07 10:23 UTC (permalink / raw)
To: Rafał Miłecki, Krzysztof Kozlowski, Conor Dooley,
Rob Herring
Cc: devicetree, linux-kernel
On Tue, 26 Sep 2023 11:45:25 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
>
>
Applied, thanks!
[1/1] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
commit: 8beb2ec54b65eb08891c9b9c23428712d46d8e15
Best regards,
--
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-07 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 16:45 [PATCH] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas Rob Herring
2023-09-27 15:11 ` Conor Dooley
2023-09-28 10:43 ` Rafał Miłecki
2023-10-07 10:23 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).