* [PATCH] arm64: dts: imx8mp-venice-gw73xx: add TPM device
@ 2023-09-26 19:43 Tim Harvey
2023-09-27 7:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Tim Harvey @ 2023-09-26 19:43 UTC (permalink / raw)
To: Shawn Guo, devicetree, linux-arm-kernel, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Tim Harvey
Add the TPM device found on the GW73xx revision F PCB.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../boot/dts/freescale/imx8mp-venice-gw73xx.dtsi | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
index 48a284478468..43e5e838cefa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
@@ -95,8 +95,17 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
&ecspi2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_spi2>;
- cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+ cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>,
+ <&gpio1 10 GPIO_ACTIVE_LOW>;
status = "okay";
+
+ tpm@1 {
+ compatible = "tcg,tpm_tis-spi";
+ #address-cells = <0x1>;
+ #size-cells = <0x1>;
+ reg = <0x1>;
+ spi-max-frequency = <36000000>;
+ };
};
&gpio4 {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mp-venice-gw73xx: add TPM device
2023-09-26 19:43 [PATCH] arm64: dts: imx8mp-venice-gw73xx: add TPM device Tim Harvey
@ 2023-09-27 7:58 ` Krzysztof Kozlowski
2023-09-28 18:01 ` Tim Harvey
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-27 7:58 UTC (permalink / raw)
To: Tim Harvey, Shawn Guo, devicetree, linux-arm-kernel, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
On 26/09/2023 21:43, Tim Harvey wrote:
> Add the TPM device found on the GW73xx revision F PCB.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> .../boot/dts/freescale/imx8mp-venice-gw73xx.dtsi | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> index 48a284478468..43e5e838cefa 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> @@ -95,8 +95,17 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> &ecspi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_spi2>;
> - cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>,
> + <&gpio1 10 GPIO_ACTIVE_LOW>;
> status = "okay";
> +
> + tpm@1 {
> + compatible = "tcg,tpm_tis-spi";
> + #address-cells = <0x1>;
> + #size-cells = <0x1>;
Why do you need these?
> + reg = <0x1>;
reg is always after compatible
> + spi-max-frequency = <36000000>;
> + };
> };
>
> &gpio4 {
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mp-venice-gw73xx: add TPM device
2023-09-27 7:58 ` Krzysztof Kozlowski
@ 2023-09-28 18:01 ` Tim Harvey
0 siblings, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2023-09-28 18:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Shawn Guo, devicetree, linux-arm-kernel, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team
On Wed, Sep 27, 2023 at 12:58 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/09/2023 21:43, Tim Harvey wrote:
> > Add the TPM device found on the GW73xx revision F PCB.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > .../boot/dts/freescale/imx8mp-venice-gw73xx.dtsi | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> > index 48a284478468..43e5e838cefa 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi
> > @@ -95,8 +95,17 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> > &ecspi2 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_spi2>;
> > - cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> > + cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>,
> > + <&gpio1 10 GPIO_ACTIVE_LOW>;
> > status = "okay";
> > +
> > + tpm@1 {
> > + compatible = "tcg,tpm_tis-spi";
> > + #address-cells = <0x1>;
> > + #size-cells = <0x1>;
>
> Why do you need these?
>
> > + reg = <0x1>;
>
> reg is always after compatible
>
> > + spi-max-frequency = <36000000>;
> > + };
> > };
> >
> > &gpio4 {
>
> Best regards,
> Krzysztof
>
Krzysztof,
Thanks for the review - I will remove the unnecessary properties with a v2
Best Regards,
Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-28 18:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 19:43 [PATCH] arm64: dts: imx8mp-venice-gw73xx: add TPM device Tim Harvey
2023-09-27 7:58 ` Krzysztof Kozlowski
2023-09-28 18:01 ` Tim Harvey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).