From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2A914A89 for ; Wed, 27 Sep 2023 06:41:10 +0000 (UTC) X-Greylist: delayed 590 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 26 Sep 2023 23:41:08 PDT Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [IPv6:2a01:4f8:150:2161:1:b009:f23e:0]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A81EEFC; Tue, 26 Sep 2023 23:41:08 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL Global TLS RSA4096 SHA256 2022 CA1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 2957A100FBD1B; Wed, 27 Sep 2023 08:31:17 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id CBB53A3DDA; Wed, 27 Sep 2023 08:31:16 +0200 (CEST) Date: Wed, 27 Sep 2023 08:31:16 +0200 From: Lukas Wunner To: Rob Herring Cc: Rob Herring , Lino Sanfilippo , linux-integrity@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Philipp Zabel , Conor Dooley Subject: Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset driver Message-ID: <20230927063116.GA6252@wunner.de> References: <169576062741.534473.12201606598910537660.robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <169576062741.534473.12201606598910537660.robh@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Sep 26, 2023 at 03:37:07PM -0500, Rob Herring wrote: > On Tue, 26 Sep 2023 21:09:35 +0200, Lukas Wunner wrote: > > A new reset driver is about to be added to perform the reset sequence of > > the Infineon SLB9670 Trusted Platform Module. > > > > Document its device tree bindings. > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml:29:111: [warning] line too long (124 > 110 characters) (line-length) That's the following line: [1] https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6 I'm not sure what to do about it. Use an URL shortener? I did see the warning when running static checks before submission, but it seemed like a false positive to me. > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/reset/infineon,slb9670-reset.example.dtb: /example-0/spi/tpm@0: failed to match any schema with compatible: ['infineon,slb9670'] The TPM DT bindings in Documentation/devicetree/bindings/security/tpm/ haven't been converted to YAML yet, hence the warning/error. Is it a prerequisite that I consolidate and convert them before this patch is acceptable? Thanks, Lukas