From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jagath Jog J <jagathjog1996@gmail.com>
Cc: jic23@kernel.org, andriy.shevchenko@linux.intel.com,
lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/2] iio: imu: Add driver for BMI323 IMU
Date: Wed, 27 Sep 2023 11:57:08 +0200 [thread overview]
Message-ID: <20230927095708.l57kmdc3mmrtaco7@pengutronix.de> (raw)
In-Reply-To: <20230918080314.11959-3-jagathjog1996@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
Hello,
On Mon, Sep 18, 2023 at 01:33:14PM +0530, Jagath Jog J wrote:
> The Bosch BMI323 is a 6-axis low-power IMU that provide measurements for
> acceleration, angular rate, and temperature. This sensor includes
> motion-triggered interrupt features, such as a step counter, tap detection,
> and activity/inactivity interrupt capabilities.
>
> The driver supports various functionalities, including data ready, FIFO
> data handling, and events such as tap detection, step counting, and
> activity interrupts
>
> Datasheet: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi323-ds000.pdf
Maybe put this link better in the driver.
> +static struct i2c_driver bmi323_i2c_driver = {
> + .driver = {
> + .name = "bmi323",
> + .of_match_table = bmi323_of_i2c_match,
> + },
> + .probe_new = bmi323_i2c_probe,
> + .id_table = bmi323_i2c_ids,
> +};
> +module_i2c_driver(bmi323_i2c_driver);
If you want to compile this driver after v6.6-rc2 (which includes
commit 5eb1e6e459cf ("i2c: Drop legacy callback .probe_new()")) better
use .probe here instead of .probe_new().
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-09-27 9:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:03 [RFC 0/2] iio: imu: Add driver and dt-bindings for BMI323 Jagath Jog J
2023-09-18 8:03 ` [RFC 1/2] dt-bindings: iio: imu: Add DT binding doc " Jagath Jog J
2023-09-18 12:25 ` Krzysztof Kozlowski
2023-09-19 16:44 ` Jagath Jog J
2023-09-24 13:31 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J
2023-09-24 13:37 ` Jonathan Cameron
2023-09-27 21:37 ` Jagath Jog J
2023-09-30 16:05 ` Jonathan Cameron
2023-10-08 6:24 ` Jagath Jog J
2023-10-10 9:00 ` Jonathan Cameron
2023-10-10 9:06 ` Linus Walleij
2023-10-10 14:42 ` Jonathan Cameron
2023-10-10 19:51 ` Linus Walleij
2023-10-13 8:16 ` Jonathan Cameron
2023-10-13 16:23 ` Jagath Jog J
2023-09-18 8:03 ` [RFC 2/2] iio: imu: Add driver for BMI323 IMU Jagath Jog J
2023-09-18 10:03 ` Andy Shevchenko
2023-09-19 22:43 ` Jagath Jog J
2023-09-20 13:24 ` Andy Shevchenko
2023-10-08 6:25 ` Jagath Jog J
2023-10-10 9:02 ` Jonathan Cameron
2023-09-24 14:30 ` Jonathan Cameron
2023-09-27 19:59 ` Jagath Jog J
2023-09-27 21:25 ` Denis Benato
2023-09-29 7:59 ` Jagath Jog J
2023-09-30 16:17 ` Jonathan Cameron
2023-10-01 13:53 ` Denis Benato
2023-10-03 20:35 ` Jagath Jog J
2023-09-30 16:13 ` Jonathan Cameron
2023-09-27 9:57 ` Uwe Kleine-König [this message]
2023-09-27 12:35 ` Andy Shevchenko
2023-09-27 14:34 ` Uwe Kleine-König
2023-10-01 8:20 ` Andy Shevchenko
2023-09-28 18:19 ` Jagath Jog J
2023-09-28 20:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927095708.l57kmdc3mmrtaco7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jagathjog1996@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).