From: Rob Herring <robh@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>,
linux-integrity@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset driver
Date: Wed, 27 Sep 2023 06:53:00 -0500 [thread overview]
Message-ID: <20230927115300.GA1587935-robh@kernel.org> (raw)
In-Reply-To: <20230927063116.GA6252@wunner.de>
On Wed, Sep 27, 2023 at 08:31:16AM +0200, Lukas Wunner wrote:
> On Tue, Sep 26, 2023 at 03:37:07PM -0500, Rob Herring wrote:
> > On Tue, 26 Sep 2023 21:09:35 +0200, Lukas Wunner wrote:
> > > A new reset driver is about to be added to perform the reset sequence of
> > > the Infineon SLB9670 Trusted Platform Module.
> > >
> > > Document its device tree bindings.
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/reset/infineon,slb9670-reset.yaml:29:111: [warning] line too long (124 > 110 characters) (line-length)
>
> That's the following line:
>
> [1] https://www.infineon.com/dgdl/Infineon-SLB%209670VQ2.0-DataSheet-v01_04-EN.pdf?fileId=5546d4626fc1ce0b016fc78270350cd6
>
> I'm not sure what to do about it. Use an URL shortener?
The link doesn't even work for me.
> I did see the warning when running static checks before submission,
> but it seemed like a false positive to me.
I suppose we could bump the limit by 1 as I think it is set to 110.
>
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/reset/infineon,slb9670-reset.example.dtb: /example-0/spi/tpm@0: failed to match any schema with compatible: ['infineon,slb9670']
>
> The TPM DT bindings in Documentation/devicetree/bindings/security/tpm/
> haven't been converted to YAML yet, hence the warning/error.
Yes, there's been multiple attempts. Everyone disappears when I say work
together and consolidate the efforts.
> Is it a prerequisite that I consolidate and convert them before
> this patch is acceptable?
Yes. Can't have warnings.
Rob
next prev parent reply other threads:[~2023-09-27 11:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 19:09 [PATCH 1/2] dt-bindings: reset: Add Infineon SLB9670 TPM reset driver Lukas Wunner
2023-09-26 19:09 ` [PATCH 2/2] " Lukas Wunner
2023-11-21 23:33 ` Francesco Dolcini
2023-11-22 7:36 ` Francesco Dolcini
2023-11-22 11:29 ` Lukas Wunner
2023-11-22 15:15 ` Francesco Dolcini
2023-11-23 8:59 ` Lukas Wunner
2023-12-18 17:34 ` Francesco Dolcini
2023-12-18 17:51 ` Lukas Wunner
2023-12-21 10:09 ` Alexander Steffen
2023-09-26 20:37 ` [PATCH 1/2] dt-bindings: " Rob Herring
2023-09-27 6:31 ` Lukas Wunner
2023-09-27 11:53 ` Rob Herring [this message]
2023-09-27 7:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927115300.GA1587935-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).