From: Abdel Alkuor <alkuor@gmail.com>
To: heikki.krogerus@linux.intel.com,
krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Abdel Alkuor <abdelalkuor@geotab.com>
Subject: [PATCH v7 05/14] USB: typec: tps6598x: Check for EEPROM present
Date: Wed, 27 Sep 2023 13:53:39 -0400 [thread overview]
Message-ID: <20230927175348.18041-6-alkuor@gmail.com> (raw)
In-Reply-To: <20230927175348.18041-1-alkuor@gmail.com>
From: Abdel Alkuor <abdelalkuor@geotab.com>
When an EEPROM is present, tps25750 loads the binary configuration from
EEPROM. Hence, all we need to do is wait for the device to switch to APP
mode
Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
---
Changes in v7:
- Add driver name to commit subject
Changes in v6:
- Update eeprom macro to use TPS instead
Changes in v5:
- Incorporating tps25750 into tps6598x driver
drivers/usb/typec/tipd/core.c | 13 +++++++++++++
drivers/usb/typec/tipd/tps6598x.h | 3 +++
2 files changed, 16 insertions(+)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index f96a9ff07fba..cd22635460d3 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -37,6 +37,7 @@
#define TPS_REG_STATUS 0x1a
#define TPS_REG_SYSTEM_CONF 0x28
#define TPS_REG_CTRL_CONF 0x29
+#define TPS_REG_BOOT_STATUS 0x2D
#define TPS_REG_POWER_STATUS 0x3f
#define TPS_REG_RX_IDENTITY_SOP 0x48
#define TPS_REG_DATA_STATUS 0x5f
@@ -910,6 +911,17 @@ static int tps25750_apply_patch(struct tps6598x *tps)
{
int ret;
unsigned long timeout;
+ u64 status = 0;
+
+ ret = tps6598x_block_read(tps, TPS_REG_BOOT_STATUS, &status, 5);
+ if (ret)
+ return ret;
+ /*
+ * Nothing to be done if the configuration
+ * is being loaded from EERPOM
+ */
+ if (status & TPS_BOOT_STATUS_I2C_EEPROM_PRESENT)
+ goto wait_for_app;
ret = tps25750_start_patch_burst_mode(tps);
if (ret) {
@@ -921,6 +933,7 @@ static int tps25750_apply_patch(struct tps6598x *tps)
if (ret)
return ret;
+wait_for_app:
timeout = jiffies + msecs_to_jiffies(1000);
do {
diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
index 527857549d69..a80d0929f3ee 100644
--- a/drivers/usb/typec/tipd/tps6598x.h
+++ b/drivers/usb/typec/tipd/tps6598x.h
@@ -199,4 +199,7 @@
#define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_A BIT(2)
#define TPS_DATA_STATUS_DP_SPEC_PIN_ASSIGNMENT_B (BIT(2) | BIT(1))
+/* BOOT STATUS REG*/
+#define TPS_BOOT_STATUS_I2C_EEPROM_PRESENT BIT(3)
+
#endif /* __TPS6598X_H__ */
--
2.34.1
next prev parent reply other threads:[~2023-09-27 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 17:53 [PATCH v7 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-28 5:37 ` Krzysztof Kozlowski
2023-09-28 8:06 ` Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 02/14] USB: typec: tsp6598x: Add cmd timeout and response delay Abdel Alkuor
2023-09-29 8:52 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 03/14] USB: typec: tps6598x: Add patch mode to tps6598x Abdel Alkuor
2023-09-29 10:11 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 04/14] USB: typec: tps6598x: Load TPS25750 patch bundle Abdel Alkuor
2023-09-29 10:29 ` Heikki Krogerus
2023-09-27 17:53 ` Abdel Alkuor [this message]
2023-09-27 17:53 ` [PATCH v7 06/14] USB: typec: tps6598x: Clear dead battery flag Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 07/14] USB: typec: tps6598x: Apply patch again after power resume Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 08/14] USB: typec: tps6598x: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-29 10:43 ` Heikki Krogerus
2023-09-27 17:53 ` [PATCH v7 09/14] USB: typec: tps6598x: Refactor tps6598x port registration Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 10/14] USB: typec: tps6598x: Add port registration for tps25750 Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 11/14] USB: typec: tps6598x: Enable sleep mode " Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 12/14] USB: typec: tps6598x: Add trace for tps25750 irq Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 13/14] USB: typec: tps6598x: Add power status trace for tps25750 Abdel Alkuor
2023-09-27 17:53 ` [PATCH v7 14/14] USB: typec: tps6598x: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927175348.18041-6-alkuor@gmail.com \
--to=alkuor@gmail.com \
--cc=abdelalkuor@geotab.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).