* [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation
@ 2023-09-27 18:16 Fabio Estevam
2023-09-28 6:23 ` Krzysztof Kozlowski
2023-09-28 9:20 ` Martin Kepplinger
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-09-27 18:16 UTC (permalink / raw)
To: mchehab
Cc: sakari.ailus, robh+dt, krzysztof.kozlowski+dt, conor+dt, martink,
linux-media, devicetree, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Document the 'orientation' and 'rotation' properties, which
are valid for the SK Hynix Hi-846 sensor.
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
index 1e2df8cf2937..ab0ff6f60fc0 100644
--- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
@@ -48,6 +48,10 @@ properties:
vddd-supply:
description: Definition of the regulator used for the VDDD power supply.
+ orientation: true
+
+ rotation: true
+
port:
$ref: /schemas/graph.yaml#/$defs/port-base
unevaluatedProperties: false
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation
2023-09-27 18:16 [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation Fabio Estevam
@ 2023-09-28 6:23 ` Krzysztof Kozlowski
2023-09-28 9:20 ` Martin Kepplinger
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-09-28 6:23 UTC (permalink / raw)
To: Fabio Estevam, mchehab
Cc: sakari.ailus, robh+dt, krzysztof.kozlowski+dt, conor+dt, martink,
linux-media, devicetree, Fabio Estevam
On 27/09/2023 20:16, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Document the 'orientation' and 'rotation' properties, which
> are valid for the SK Hynix Hi-846 sensor.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation
2023-09-27 18:16 [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation Fabio Estevam
2023-09-28 6:23 ` Krzysztof Kozlowski
@ 2023-09-28 9:20 ` Martin Kepplinger
2023-09-28 12:13 ` Fabio Estevam
1 sibling, 1 reply; 4+ messages in thread
From: Martin Kepplinger @ 2023-09-28 9:20 UTC (permalink / raw)
To: Fabio Estevam, mchehab
Cc: sakari.ailus, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-media, devicetree, Fabio Estevam
Am Mittwoch, dem 27.09.2023 um 15:16 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Document the 'orientation' and 'rotation' properties, which
> are valid for the SK Hynix Hi-846 sensor.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 4
> ++++
> 1 file changed, 4 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 1e2df8cf2937..ab0ff6f60fc0 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -48,6 +48,10 @@ properties:
> vddd-supply:
> description: Definition of the regulator used for the VDDD power
> supply.
>
> + orientation: true
> +
> + rotation: true
> +
> port:
> $ref: /schemas/graph.yaml#/$defs/port-base
> unevaluatedProperties: false
hi Fabio,
thanks a lot, I like to have this fixed. I always thought we could re-
use media/video-interface-devices.yaml for these properties somehow...
if your change is preferred,
Acked-by: Martin Kepplinger <martink@posteo.de>
martin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation
2023-09-28 9:20 ` Martin Kepplinger
@ 2023-09-28 12:13 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-09-28 12:13 UTC (permalink / raw)
To: Martin Kepplinger
Cc: Fabio Estevam, mchehab, sakari.ailus, robh+dt,
krzysztof.kozlowski+dt, conor+dt, linux-media, devicetree
Hi Martin,
On 28/09/2023 06:20, Martin Kepplinger wrote:
unevaluatedProperties: false
>
> hi Fabio,
>
> thanks a lot, I like to have this fixed. I always thought we could re-
> use media/video-interface-devices.yaml for these properties somehow...
>
> if your change is preferred,
>
> Acked-by: Martin Kepplinger <martink@posteo.de>
Good point on video-interface-devices.yaml.
Indeed, we should pass a reference to it.
Otherwise, after this patch, hynix,hi846.yaml will only check for the
presence of
orientation/rotation properties and not check whether the values are
valid.
I will submit a v2 that adds the aditional ref to
video-interface-devices.yaml
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-28 12:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 18:16 [PATCH] media: dt-bindings: hynix,hi846: Document orientation and rotation Fabio Estevam
2023-09-28 6:23 ` Krzysztof Kozlowski
2023-09-28 9:20 ` Martin Kepplinger
2023-09-28 12:13 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).