From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org
Subject: [PATCH v6 00/36] ARM: dts: qcom: cleanup PMIC usage
Date: Thu, 28 Sep 2023 14:02:33 +0300 [thread overview]
Message-ID: <20230928110309.1212221-1-dmitry.baryshkov@linaro.org> (raw)
While reviewing APQ8064 CPUFreq patchset, Konrad pointed out that PMICs
are not a part of SoC and as such do not belong to the per-SoC files.
Cleanup the way 32-bit Qualcomm platforms treat PMICs:
- Move SSBI PMICs to separate files (as a bonus merging two different
instances of PM8921, benefitting both platforms).
- Include such PMIC files only from the board files, keeping SoC file
generic.
- Move RPM regulator definitions to board files too. They do not belong
to the SoC dtsi files for the same reason.
- Move PMIC-specific GPIOs and supply properties to individual board
files.
Note, enabling DT schema triggers warnings for pmic:led@48 in
qcom-apq8060-dragonboard.dts. This node uses custom ('cm3605') trigger
to make the LED follow the state of the proximity / ALS device.
Previously [1] Rob pointed out that this is not the best way and the
device should be switched to `trigger-sources' instead. However as I do
not have this device, I'm not brave enough to introduce these changes.
Note2: DT binding changes are largely independent from the DTS changes,
they can be applied separately.
[1] https://lore.kernel.org/linux-arm-msm/20221205220709.GA2713165-robh@kernel.org
Changes since v5:
- Dropped accepted patches
- Provided proper commit message for the last two patches (Konrad)
Changes since v4:
- Rebased on top of linux-next
Changes since v3:
- Dropped the interrupts/interrupts-extended patch, it is handled by
dtschema itself (Krzysztof)
Changes since v3:
- Moved PMIC interrupts to board DT files, they are not a property of
the board, not the SoC.
- Dropped qcom, prefix from ssbi node names in ipq8064 and mdm9615 DT
files.
Changes since v2:
- Rebased on top of linux-next to fix conflict
- Picked up dt-bindings patches from old, not-fully merged series.
- qcom,pm8921-keypad: droped the no-autorepeat property (Rob, Dmitry)
- Moved qcom,ssbi to /bus/ (Krzysztof)
Changes since v1:
- To ease reviewing break cleanups from the "split PMIC" patches
(Konrad).
Dmitry Baryshkov (36):
dt-bindings: input: qcom,pm8921-keypad: convert to YAML format
ARM: dts: qcom: apq8064: correct XOADC register address
ARM: dts: qcom: msm8960: introduce label for PMIC keypad
ARM: dts: qcom: msm8660-surf: use keypad label directly
ARM: dts: qcom: apq8064-nexus7: move sdcc1 node to proper place
ARM: dts: qcom: mdm9615-wp8548-mangoh-green: group include clauses
ARM: dts: qcom: strip prefix from PMIC files
ARM: dts: qcom: apq8064: fix PMIC node labels
ARM: dts: qcom: mdm9615: fix PMIC node labels
ARM: dts: qcom: msm8660: fix PMIC node labels
ARM: dts: qcom: msm8960: fix PMIC node labels
ARM: dts: qcom: apq8064: move PMIC interrupts to the board files
ARM: dts: qcom: mdm9615: move PMIC interrupts to the board files
ARM: dts: qcom: msm8660: move PMIC interrupts to the board files
ARM: dts: qcom: msm8960: move PMIC interrupts to the board files
ARM: dts: qcom: msm8960: split PMIC to separate dtsi files
ARM: dts: qcom: apq8064: split PMICs to separate dtsi files
ARM: dts: qcom: mdm9615: split PMIC to separate dtsi files
ARM: dts: qcom: msm8660: split PMIC to separate dtsi files
ARM: dts: qcom: pm8058: reorder nodes
ARM: dts: qcom: pm8921: reorder nodes
ARM: dts: qcom: pm8018: move reg property
ARM: dts: qcom: pm8921: move reg property
ARM: dts: qcom: pm8058: use defined IRQ flags
ARM: dts: qcom: pm8921: switch to interrupts-extended
ARM: dts: qcom: pm8018: switch to interrupts-extended
ARM: dts: qcom: pm8058: switch to interrupts-extended
ARM: dts: qcom: apq8064: move RPM regulators to board files
ARM: dts: qcom: mdm9615: move RPM regulators to board files
ARM: dts: qcom: msm8660: move RPM regulators to board files
ARM: dts: qcom: msm8960: drop useless rpm regulators node
ARM: dts: qcom: msm8974: move regulators to board files
ARM: dts: qcom: pm8921: Disable keypad by default
ARM: dts: qcom: apq8060-dragonboard: rename mpp ADC channels to
adc-channel
ARM: dts: qcom: ipq8064: drop qcom, prefix from SSBI node name
ARM: dts: qcom: mdm9615: drop qcom, prefix from SSBI node name
.../bindings/input/qcom,pm8921-keypad.yaml | 89 +++++++
.../bindings/input/qcom,pm8xxx-keypad.txt | 90 --------
arch/arm/boot/dts/qcom/pm8018.dtsi | 55 +++++
arch/arm/boot/dts/qcom/pm8058.dtsi | 159 +++++++++++++
.../qcom/{qcom-pm8226.dtsi => pm8226.dtsi} | 0
arch/arm/boot/dts/qcom/pm8821.dtsi | 22 ++
.../qcom/{qcom-pm8841.dtsi => pm8841.dtsi} | 0
arch/arm/boot/dts/qcom/pm8921.dtsi | 137 +++++++++++
.../qcom/{qcom-pm8941.dtsi => pm8941.dtsi} | 0
.../qcom/{qcom-pma8084.dtsi => pma8084.dtsi} | 0
.../dts/qcom/{qcom-pmx55.dtsi => pmx55.dtsi} | 0
.../dts/qcom/{qcom-pmx65.dtsi => pmx65.dtsi} | 0
.../dts/qcom/qcom-apq8026-asus-sparrow.dts | 2 +-
.../dts/qcom/qcom-apq8026-huawei-sturgeon.dts | 2 +-
.../boot/dts/qcom/qcom-apq8026-lg-lenok.dts | 2 +-
.../qcom-apq8026-samsung-matisse-wifi.dts | 2 +-
.../dts/qcom/qcom-apq8060-dragonboard.dts | 164 ++++++++-----
.../dts/qcom/qcom-apq8064-asus-nexus7-flo.dts | 70 +++---
.../boot/dts/qcom/qcom-apq8064-cm-qs600.dts | 35 ++-
.../boot/dts/qcom/qcom-apq8064-ifc6410.dts | 42 ++--
.../qcom-apq8064-sony-xperia-lagan-yuga.dts | 111 +++++----
arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 201 +---------------
.../dts/qcom/qcom-apq8074-dragonboard.dts | 31 ++-
.../boot/dts/qcom/qcom-apq8084-ifc6540.dts | 2 +-
arch/arm/boot/dts/qcom/qcom-apq8084-mtp.dts | 2 +-
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 2 +-
.../qcom/qcom-mdm9615-wp8548-mangoh-green.dts | 4 +-
.../boot/dts/qcom/qcom-mdm9615-wp8548.dtsi | 143 +++++++++++-
arch/arm/boot/dts/qcom/qcom-mdm9615.dtsi | 183 +--------------
arch/arm/boot/dts/qcom/qcom-msm8660-surf.dts | 61 +++--
arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 217 +-----------------
arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts | 27 ++-
.../qcom/qcom-msm8960-samsung-expressatt.dts | 7 +-
arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 45 +---
.../qcom-msm8974-lge-nexus5-hammerhead.dts | 31 ++-
.../qcom/qcom-msm8974-sony-xperia-rhine.dtsi | 31 ++-
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 27 ---
.../qcom/qcom-msm8974pro-fairphone-fp2.dts | 31 ++-
.../qcom/qcom-msm8974pro-oneplus-bacon.dts | 31 ++-
.../dts/qcom/qcom-msm8974pro-samsung-klte.dts | 12 +-
...-msm8974pro-sony-xperia-shinano-castor.dts | 31 ++-
arch/arm/boot/dts/qcom/qcom-sdx55-mtp.dts | 2 +-
arch/arm/boot/dts/qcom/qcom-sdx55-t55.dts | 2 +-
.../dts/qcom/qcom-sdx55-telit-fn980-tlb.dts | 2 +-
arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
45 files changed, 1137 insertions(+), 972 deletions(-)
create mode 100644 Documentation/devicetree/bindings/input/qcom,pm8921-keypad.yaml
delete mode 100644 Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
create mode 100644 arch/arm/boot/dts/qcom/pm8018.dtsi
create mode 100644 arch/arm/boot/dts/qcom/pm8058.dtsi
rename arch/arm/boot/dts/qcom/{qcom-pm8226.dtsi => pm8226.dtsi} (100%)
create mode 100644 arch/arm/boot/dts/qcom/pm8821.dtsi
rename arch/arm/boot/dts/qcom/{qcom-pm8841.dtsi => pm8841.dtsi} (100%)
create mode 100644 arch/arm/boot/dts/qcom/pm8921.dtsi
rename arch/arm/boot/dts/qcom/{qcom-pm8941.dtsi => pm8941.dtsi} (100%)
rename arch/arm/boot/dts/qcom/{qcom-pma8084.dtsi => pma8084.dtsi} (100%)
rename arch/arm/boot/dts/qcom/{qcom-pmx55.dtsi => pmx55.dtsi} (100%)
rename arch/arm/boot/dts/qcom/{qcom-pmx65.dtsi => pmx65.dtsi} (100%)
--
2.39.2
next reply other threads:[~2023-09-28 11:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 11:02 Dmitry Baryshkov [this message]
2023-09-28 11:02 ` [PATCH v6 01/36] dt-bindings: input: qcom,pm8921-keypad: convert to YAML format Dmitry Baryshkov
2023-10-30 20:04 ` Rob Herring
2023-09-28 11:02 ` [PATCH v6 02/36] ARM: dts: qcom: apq8064: correct XOADC register address Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 03/36] ARM: dts: qcom: msm8960: introduce label for PMIC keypad Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 04/36] ARM: dts: qcom: msm8660-surf: use keypad label directly Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 05/36] ARM: dts: qcom: apq8064-nexus7: move sdcc1 node to proper place Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 06/36] ARM: dts: qcom: mdm9615-wp8548-mangoh-green: group include clauses Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 07/36] ARM: dts: qcom: strip prefix from PMIC files Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 08/36] ARM: dts: qcom: apq8064: fix PMIC node labels Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 09/36] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 10/36] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 11/36] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 12/36] ARM: dts: qcom: apq8064: move PMIC interrupts to the board files Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 13/36] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 14/36] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 15/36] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 16/36] ARM: dts: qcom: msm8960: split PMIC to separate dtsi files Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 17/36] ARM: dts: qcom: apq8064: split PMICs " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 18/36] ARM: dts: qcom: mdm9615: split PMIC " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 19/36] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 20/36] ARM: dts: qcom: pm8058: reorder nodes Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 21/36] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 22/36] ARM: dts: qcom: pm8018: move reg property Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 23/36] ARM: dts: qcom: pm8921: " Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 24/36] ARM: dts: qcom: pm8058: use defined IRQ flags Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 25/36] ARM: dts: qcom: pm8921: switch to interrupts-extended Dmitry Baryshkov
2023-09-28 11:02 ` [PATCH v6 26/36] ARM: dts: qcom: pm8018: " Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 27/36] ARM: dts: qcom: pm8058: " Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 28/36] ARM: dts: qcom: apq8064: move RPM regulators to board files Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 29/36] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 30/36] ARM: dts: qcom: msm8660: " Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 31/36] ARM: dts: qcom: msm8960: drop useless rpm regulators node Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 32/36] ARM: dts: qcom: msm8974: move regulators to board files Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 33/36] ARM: dts: qcom: pm8921: Disable keypad by default Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 34/36] ARM: dts: qcom: apq8060-dragonboard: rename mpp ADC channels to adc-channel Dmitry Baryshkov
2023-09-28 11:03 ` [PATCH v6 35/36] ARM: dts: qcom: ipq8064: drop qcom, prefix from SSBI node name Dmitry Baryshkov
2023-09-28 13:49 ` Konrad Dybcio
2023-09-28 11:03 ` [PATCH v6 36/36] ARM: dts: qcom: mdm9615: " Dmitry Baryshkov
2023-09-28 13:50 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928110309.1212221-1-dmitry.baryshkov@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).