From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Eliza Balas <eliza.balas@analog.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drivers: misc: adi-axi-tdd: Add TDD engine
Date: Thu, 28 Sep 2023 14:23:04 +0200 [thread overview]
Message-ID: <2023092835-educator-cardigan-1ae0@gregkh> (raw)
In-Reply-To: <20230928092804.22612-3-eliza.balas@analog.com>
On Thu, Sep 28, 2023 at 12:28:04PM +0300, Eliza Balas wrote:
> --- /dev/null
> +++ b/drivers/misc/adi-axi-tdd.c
> @@ -0,0 +1,780 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
License comment, why is this dual licensed? You are calling
gpl-only-marked functions in this driver so attempting to say it is also
BSD is quite odd, how are you going to resolve that?
Has a lawyer agreed with this licensing?
Please get a lawyer to sign off on your next contribution of this with a
dual license to ensure that they agree and that you all fully understand
the legal issues and complexity of attempting to have dual-licensed
Linux kernel code (hint, it's not as simple as you might think...)
And document in the changelog _why_ you want this to be dual licensed so
that we can all review that as well.
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-28 12:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 9:28 [PATCH v2 0/2] Add support for ADI TDD Engine Eliza Balas
2023-09-28 9:28 ` [PATCH v2 1/2] dt-bindings: misc: adi,axi-tdd: Add device-tree binding for TDD engine Eliza Balas
2023-10-02 16:32 ` Rob Herring
2023-10-02 16:46 ` Balas, Eliza
2023-10-02 19:21 ` Conor Dooley
2023-10-02 19:48 ` Balas, Eliza
2023-10-02 20:07 ` Conor Dooley
2023-10-02 20:23 ` Balas, Eliza
2023-10-03 8:54 ` Krzysztof Kozlowski
2023-09-28 9:28 ` [PATCH v2 2/2] drivers: misc: adi-axi-tdd: Add " Eliza Balas
2023-09-28 10:07 ` Arnd Bergmann
2023-09-28 10:54 ` Balas, Eliza
2023-09-28 12:30 ` Nuno Sá
2023-09-28 14:19 ` Arnd Bergmann
2023-09-28 16:35 ` Nuno Sá
2023-10-02 16:02 ` Balas, Eliza
2023-09-28 11:52 ` Nuno Sá
2023-09-28 12:23 ` Greg Kroah-Hartman [this message]
2023-09-28 14:05 ` Balas, Eliza
2023-09-28 9:38 ` [PATCH v2 0/2] Add support for ADI TDD Engine Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023092835-educator-cardigan-1ae0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=eliza.balas@analog.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).