From: Piyush Mehta <piyush.mehta@amd.com>
To: <gregkh@linuxfoundation.org>, <michal.simek@amd.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <peter.chen@kernel.org>,
<linus.walleij@linaro.org>, <paul@crapouillou.net>,
<arnd@arndb.de>
Cc: <piyush.mehta@amd.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<git@amd.com>
Subject: [RFC PATCH 0/3] usb: phy: Add platform driver support for ULPI phys
Date: Fri, 29 Sep 2023 12:18:49 +0530 [thread overview]
Message-ID: <20230929064852.16642-1-piyush.mehta@amd.com> (raw)
Added USB2 phy for Zynq platform and converted ULPI framework to platform
driver to drive CPEN to enable external 5 volt supply when Zynq USB is in
host mode.
---
On zynq platform chipidea USB controller is capable of fulfilling a wide
range of applications for USB 2.0 implementations as a host, a device, or
On-the-Go. The USB controllers are integrated into the PS IOP to bridge
between the PS interconnect and an external ULPI PHY. The register provides
indirect access to the ULPI PHY register set. The ULPI PHY register I/O
interface uses Viewport to access PHY registers.
In current approach we have extended generic ulpi phy driver and made it a
platform driver. This solves the problem, but would like to know if it is
the right approach?
The another approach would be to have access to the ULPI register via
viewport flow by creating a new platform driver at path "driver/usb/phy"
using "phy-ulpi-zynq-usb.c" source file, where the source driver would be
particular to the Xilinx/AMD zynq platform. And binding patch [1/3] would
be specific to Xilinx/AMD-specific.
We need your inputs in order to have access to the ULPI register via
viewport flow.
---
drivers/usb/phy/Kconfig | 2 +-
Piyush Mehta (3):
dt-binding: usb: ulpi-phy: add ulpi-phy binding
usb: chipidea: add usb2 phy interface for Zynq platform
usb: phy: Add platform driver support for ULPI phys
.../devicetree/bindings/usb/ulpi-phy.yaml | 48 ++++++++++
drivers/usb/chipidea/ci_hdrc_usb2.c | 8 ++
drivers/usb/phy/Kconfig | 2 +-
drivers/usb/phy/phy-ulpi.c | 90 +++++++++++++++++++
4 files changed, 147 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/usb/ulpi-phy.yaml
--
2.17.1
next reply other threads:[~2023-09-29 6:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 6:48 Piyush Mehta [this message]
2023-09-29 6:48 ` [RFC PATCH 1/3] dt-binding: usb: ulpi-phy: add ulpi-phy binding Piyush Mehta
2023-09-29 14:04 ` Conor Dooley
2023-09-30 15:15 ` Krzysztof Kozlowski
2023-10-02 17:00 ` Rob Herring
2023-10-04 11:45 ` Mehta, Piyush
2023-12-01 13:07 ` Mehta, Piyush
2023-09-29 6:48 ` [RFC PATCH 2/3] usb: chipidea: add usb2 phy interface for Zynq platform Piyush Mehta
2023-09-29 6:48 ` [RFC PATCH 3/3] usb: phy: Add platform driver support for ULPI phys Piyush Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929064852.16642-1-piyush.mehta@amd.com \
--to=piyush.mehta@amd.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=paul@crapouillou.net \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).