From: Jon Hunter <jonathanh@nvidia.com>
To: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH V5 0/4] hwmon: ina3221: Add selective summation support
Date: Fri, 29 Sep 2023 11:36:46 +0100 [thread overview]
Message-ID: <20230929103650.86074-1-jonathanh@nvidia.com> (raw)
The current INA3221 driver always sums the shunt voltage for all enabled
channels regardless of the shunt-resistor used for each channel. Summing
the shunt-voltage for channels is only meaningful if the shunt resistor
is the same for each channel. This series adds device-tree support to
allow which channels are summed in device-tree.
Changes since V4:
- Moved dt-binding comment added in V4 from patch #2 to patch #1.
Changes since V3:
- Added missing descriptions for new structure members that was reported
by the kernel-test-bot.
- Added comment in the ina3221 dt-binding doc example to explain why we
need to explicitly disable channels.
- Added more commentary in the commit message for the new DT property
to explain that this property does not change the behaviour of the
driver unless it is populated.
Changes since V2:
- Added note to binding-doc to indicate that input channels must be
explicitly disabled.
- Corrected ordering of properties in the binding-doc
- Updated license for the binding-doc to be dual licensed.
- Changed newly added property from 'summation-bypass' to
summation-disable'.
- Documented type for the new 'summation-disable' property.
- Corrected spelling and comments as per the feedback received.
- Used debugfs instead of sysfs for exposing the 'summation-disable'
status for each input channel.
- Populated missing instances for the ina3221 device for Tegra234
boards.
- Populated ina219 device for the NVIDIA IGX board (not strictly
related to this series but related to populating all
power-sensors for Tegra234 boards)
Changes since V1:
- Added yaml conversion patch for binding-doc
- Added binding-doc documentation patch for new property
- Added patch to populate ina3221 devices for Tegra234.
Jon Hunter (2):
dt-bindings: hwmon: ina3221: Add ti,summation-disable
arm64: tegra: Add power-sensors for Tegra234 boards
Ninad Malwade (2):
dt-bindings: hwmon: ina3221: Convert to json-schema
hwmon: ina3221: Add support for channel summation disable
.../devicetree/bindings/hwmon/ina3221.txt | 54 --------
.../devicetree/bindings/hwmon/ti,ina3221.yaml | 121 ++++++++++++++++++
.../boot/dts/nvidia/tegra234-p3701-0008.dtsi | 33 +++++
.../arm64/boot/dts/nvidia/tegra234-p3701.dtsi | 53 ++++++++
.../arm64/boot/dts/nvidia/tegra234-p3767.dtsi | 29 +++++
drivers/hwmon/ina3221.c | 33 ++++-
6 files changed, 266 insertions(+), 57 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/hwmon/ina3221.txt
create mode 100644 Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
--
2.34.1
next reply other threads:[~2023-09-29 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 10:36 Jon Hunter [this message]
2023-09-29 10:36 ` [PATCH V5 1/4] dt-bindings: hwmon: ina3221: Convert to json-schema Jon Hunter
2023-10-02 17:19 ` Rob Herring
2023-10-26 0:58 ` Guenter Roeck
2023-09-29 10:36 ` [PATCH V5 2/4] dt-bindings: hwmon: ina3221: Add ti,summation-disable Jon Hunter
2023-10-02 17:20 ` Rob Herring
2023-10-26 0:59 ` Guenter Roeck
2023-09-29 10:36 ` [PATCH V5 3/4] hwmon: ina3221: Add support for channel summation disable Jon Hunter
2023-10-11 8:15 ` Jon Hunter
2023-10-26 0:59 ` Guenter Roeck
2023-09-29 10:36 ` [PATCH V5 4/4] arm64: tegra: Add power-sensors for Tegra234 boards Jon Hunter
2023-10-11 20:28 ` [PATCH V5 0/4] hwmon: ina3221: Add selective summation support Thierry Reding
2023-10-25 10:54 ` Jon Hunter
2023-10-13 12:36 ` (subset) " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230929103650.86074-1-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).