devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices
@ 2023-09-29 15:05 Joerg Schambacher
  2023-10-02 15:16 ` Rob Herring
  2023-10-03 13:19 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Joerg Schambacher @ 2023-09-29 15:05 UTC (permalink / raw)
  Cc: a-krasser, joerg, Joerg Schambacher, Liam Girdwood, Mark Brown,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, alsa-devel,
	devicetree, linux-kernel

The TAS5754/6 power amplifiers use the same pcm512x driver with
only minor restictions described in the bindings document.

Signed-off-by: Joerg Schambacher <joerg.hifiberry@gmail.com>
---
 Documentation/devicetree/bindings/sound/pcm512x.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/pcm512x.txt b/Documentation/devicetree/bindings/sound/pcm512x.txt
index 3aae3b41bd8e..77006a4aec4a 100644
--- a/Documentation/devicetree/bindings/sound/pcm512x.txt
+++ b/Documentation/devicetree/bindings/sound/pcm512x.txt
@@ -1,12 +1,12 @@
-PCM512x audio CODECs
+PCM512x and TAS575x audio CODECs/amplifiers
 
 These devices support both I2C and SPI (configured with pin strapping
-on the board).
+on the board). The TAS575x devices only support I2C.
 
 Required properties:
 
-  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141" or
-                 "ti,pcm5142"
+  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141",
+                 "ti,pcm5142", "ti,tas5754" or "ti,tas5756"
 
   - reg : the I2C address of the device for I2C, the chip select
           number for SPI.
@@ -25,6 +25,7 @@ Optional properties:
     through <6>.  The device will be configured for clock input on the
     given pll-in pin and PLL output on the given pll-out pin.  An
     external connection from the pll-out pin to the SCLK pin is assumed.
+    Caution: the TAS-desvices only support gpios 1,2 and 3
 
 Examples:
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices
  2023-09-29 15:05 [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices Joerg Schambacher
@ 2023-10-02 15:16 ` Rob Herring
  2023-10-03 13:19 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-10-02 15:16 UTC (permalink / raw)
  To: Joerg Schambacher
  Cc: Mark Brown, Liam Girdwood, Krzysztof Kozlowski, Rob Herring,
	alsa-devel, linux-kernel, a-krasser, joerg, Conor Dooley,
	devicetree


On Fri, 29 Sep 2023 17:05:55 +0200, Joerg Schambacher wrote:
> The TAS5754/6 power amplifiers use the same pcm512x driver with
> only minor restictions described in the bindings document.
> 
> Signed-off-by: Joerg Schambacher <joerg.hifiberry@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/pcm512x.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 


Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

Missing tags:

Reviewed-by: Rob Herring <robh@kernel.org>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices
  2023-09-29 15:05 [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices Joerg Schambacher
  2023-10-02 15:16 ` Rob Herring
@ 2023-10-03 13:19 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2023-10-03 13:19 UTC (permalink / raw)
  To: Joerg Schambacher
  Cc: a-krasser, joerg, Liam Girdwood, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, alsa-devel, devicetree, linux-kernel

On Fri, 29 Sep 2023 17:05:55 +0200, Joerg Schambacher wrote:
> The TAS5754/6 power amplifiers use the same pcm512x driver with
> only minor restictions described in the bindings document.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: pcm512x: Adds bindings for TAS575x devices
      commit: 736b884a7b68c4eeb66dbf75b97c8ec9b9eeff7f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-03 13:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-29 15:05 [PATCH v2 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices Joerg Schambacher
2023-10-02 15:16 ` Rob Herring
2023-10-03 13:19 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).