From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: andersson@kernel.org, agross@kernel.org,
konrad.dybcio@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jonathan@marek.ca, quic_tdas@quicinc.com,
vladimir.zapolskiy@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bryan.odonoghue@linaro.org
Subject: [PATCH v2 1/5] dt-bindings: clock: qcom,camcc-common.yaml: Add a common file for camcc
Date: Sat, 30 Sep 2023 14:41:10 +0100 [thread overview]
Message-ID: <20230930134114.1816590-2-bryan.odonoghue@linaro.org> (raw)
In-Reply-To: <20230930134114.1816590-1-bryan.odonoghue@linaro.org>
Various of the camcc bindings are repeated serially. Aggregate the
common defintions into one place declaring common required in one place
also.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/clock/qcom,camcc-common.yaml | 44 +++++++++++++++++++
.../bindings/clock/qcom,camcc-sm8250.yaml | 32 ++------------
.../bindings/clock/qcom,sc7180-camcc.yaml | 23 ++--------
.../bindings/clock/qcom,sc7280-camcc.yaml | 23 ++--------
.../bindings/clock/qcom,sdm845-camcc.yaml | 23 ++--------
.../bindings/clock/qcom,sm6350-camcc.yaml | 13 ++----
.../bindings/clock/qcom,sm8450-camcc.yaml | 33 ++------------
7 files changed, 67 insertions(+), 124 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
diff --git a/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
new file mode 100644
index 000000000000..ce0140985fe7
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,camcc-common.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,camcc-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Camera Clock & Reset Controller common properties
+
+maintainers:
+ - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
+
+description: |
+ Qualcomm camera clock control module provides the clocks, resets and power
+ domains on Qualcomm SoCs.
+
+allOf:
+ - $ref: qcom,gcc.yaml#
+
+properties:
+ compatible: true
+
+ clocks:
+ minItems: 1
+ maxItems: 4
+
+ clock-names:
+ minItems: 1
+ maxItems: 4
+
+ power-domains:
+ maxItems: 1
+ description:
+ A phandle and PM domain specifier for the MMCX power domain.
+
+ required-opps:
+ maxItems: 1
+ description:
+ OPP node describing required MMCX performance point.
+
+required:
+ - compatible
+ - clocks
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/clock/qcom,camcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,camcc-sm8250.yaml
index 426335a2841c..e31b20076643 100644
--- a/Documentation/devicetree/bindings/clock/qcom,camcc-sm8250.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,camcc-sm8250.yaml
@@ -15,6 +15,9 @@ description: |
See also:: include/dt-bindings/clock/qcom,camcc-sm8250.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
const: qcom,sm8250-camcc
@@ -33,37 +36,10 @@ properties:
- const: bi_tcxo_ao
- const: sleep_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- power-domains:
- items:
- - description: MMCX power domain
-
- reg:
- maxItems: 1
-
- required-opps:
- maxItems: 1
- description:
- OPP node describing required MMCX performance point.
-
required:
- - compatible
- - reg
- - clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- - '#power-domain-cells'
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml
index 2dfc2a4f1918..40cef12d67e0 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7180-camcc.yaml
@@ -15,6 +15,9 @@ description: |
See also:: include/dt-bindings/clock/qcom,camcc-sc7180.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
const: qcom,sc7180-camcc
@@ -31,28 +34,10 @@ properties:
- const: iface
- const: xo
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- - compatible
- - reg
- - clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- - '#power-domain-cells'
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/clock/qcom,sc7280-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc7280-camcc.yaml
index 01feef1cab0a..057f93b4971b 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc7280-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc7280-camcc.yaml
@@ -15,6 +15,9 @@ description: |
See also:: include/dt-bindings/clock/qcom,camcc-sc7280.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
const: qcom,sc7280-camcc
@@ -31,28 +34,10 @@ properties:
- const: bi_tcxo_ao
- const: sleep_clk
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- - compatible
- - reg
- - clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- - '#power-domain-cells'
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/clock/qcom,sdm845-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sdm845-camcc.yaml
index 91d1f7918037..553fae55bc66 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sdm845-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sdm845-camcc.yaml
@@ -15,6 +15,9 @@ description: |
See also:: include/dt-bindings/clock/qcom,camcc-sm845.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
const: qcom,sdm845-camcc
@@ -27,28 +30,10 @@ properties:
items:
- const: bi_tcxo
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- - compatible
- - reg
- - clocks
- clock-names
- - '#clock-cells'
- - '#reset-cells'
- - '#power-domain-cells'
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6350-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6350-camcc.yaml
index fd6658cb793d..5a004396659b 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm6350-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm6350-camcc.yaml
@@ -15,6 +15,9 @@ description: |
See also:: include/dt-bindings/clock/qcom,sm6350-camcc.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
const: qcom,sm6350-camcc
@@ -23,16 +26,6 @@ properties:
items:
- description: Board XO source
- reg:
- maxItems: 1
-
-required:
- - compatible
- - clocks
-
-allOf:
- - $ref: qcom,gcc.yaml#
-
unevaluatedProperties: false
examples:
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index dc3c18e4ead7..5db7bd8424d8 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -17,6 +17,9 @@ description: |
include/dt-bindings/clock/qcom,sm8450-camcc.h
include/dt-bindings/clock/qcom,sm8550-camcc.h
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
properties:
compatible:
enum:
@@ -30,39 +33,11 @@ properties:
- description: Board active XO source
- description: Sleep clock source
- power-domains:
- maxItems: 1
- description:
- A phandle and PM domain specifier for the MMCX power domain.
-
- required-opps:
- maxItems: 1
- description:
- A phandle to an OPP node describing required MMCX performance point.
-
- '#clock-cells':
- const: 1
-
- '#reset-cells':
- const: 1
-
- '#power-domain-cells':
- const: 1
-
- reg:
- maxItems: 1
-
required:
- - compatible
- - reg
- - clocks
- power-domains
- required-opps
- - '#clock-cells'
- - '#reset-cells'
- - '#power-domain-cells'
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.40.1
next prev parent reply other threads:[~2023-09-30 13:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 13:41 [PATCH v2 0/5] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-09-30 13:41 ` Bryan O'Donoghue [this message]
2023-09-30 14:14 ` [PATCH v2 1/5] dt-bindings: clock: qcom,camcc-common.yaml: Add a common file for camcc Krzysztof Kozlowski
2023-09-30 13:41 ` [PATCH v2 2/5] dt-bindings: clock: Add SM8550 CAMCC yaml Bryan O'Donoghue
2023-09-30 14:15 ` Krzysztof Kozlowski
2023-09-30 13:41 ` [PATCH v2 3/5] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-09-30 13:41 ` [PATCH v2 4/5] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-09-30 16:39 ` Konrad Dybcio
2023-09-30 22:53 ` Bryan O'Donoghue
2023-10-02 9:17 ` Konrad Dybcio
2023-09-30 13:41 ` [PATCH v2 5/5] arm64: boot: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
2023-09-30 14:16 ` Krzysztof Kozlowski
2023-09-30 16:41 ` Konrad Dybcio
2023-09-30 23:01 ` Bryan O'Donoghue
2023-10-02 9:56 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930134114.1816590-2-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).