From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: andersson@kernel.org, agross@kernel.org,
konrad.dybcio@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jonathan@marek.ca, quic_tdas@quicinc.com,
vladimir.zapolskiy@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bryan.odonoghue@linaro.org
Subject: [PATCH v2 2/5] dt-bindings: clock: Add SM8550 CAMCC yaml
Date: Sat, 30 Sep 2023 14:41:11 +0100 [thread overview]
Message-ID: <20230930134114.1816590-3-bryan.odonoghue@linaro.org> (raw)
In-Reply-To: <20230930134114.1816590-1-bryan.odonoghue@linaro.org>
The SM8550 should have its own yaml description file, not be listed as a
compatible string of the SM8450 CAMCC driver since SM8450 and SM8550
have separate CAMCC drivers.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/clock/qcom,sm8450-camcc.yaml | 8 +--
.../bindings/clock/qcom,sm8550-camcc.yaml | 56 +++++++++++++++++++
2 files changed, 58 insertions(+), 6 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm8550-camcc.yaml
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
index 5db7bd8424d8..9d16acc53312 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml
@@ -13,18 +13,14 @@ description: |
Qualcomm camera clock control module provides the clocks, resets and power
domains on SM8450.
- See also::
- include/dt-bindings/clock/qcom,sm8450-camcc.h
- include/dt-bindings/clock/qcom,sm8550-camcc.h
+ See also:: include/dt-bindings/clock/qcom,sm8450-camcc.h
allOf:
- $ref: qcom,camcc-common.yaml#
properties:
compatible:
- enum:
- - qcom,sm8450-camcc
- - qcom,sm8550-camcc
+ const: qcom,sm8450-camcc
clocks:
items:
diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-camcc.yaml
new file mode 100644
index 000000000000..93534632c0a2
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-camcc.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,sm8550-camcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Camera Clock & Reset Controller on SM8550
+
+maintainers:
+ - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
+
+description: |
+ Qualcomm camera clock control module provides the clocks, resets and power
+ domains on SM8550.
+
+ See also:: include/dt-bindings/clock/qcom,sm8550-camcc.h
+
+allOf:
+ - $ref: qcom,camcc-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,sm8550-camcc
+
+ clocks:
+ items:
+ - description: Camera AHB clock from GCC
+ - description: Board XO source
+ - description: Board active XO source
+ - description: Sleep clock source
+
+required:
+ - power-domains
+ - required-opps
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,sm8550-gcc.h>
+ #include <dt-bindings/clock/qcom,rpmh.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+ clock-controller@ade0000 {
+ compatible = "qcom,sm8550-camcc";
+ reg = <0xade0000 0x20000>;
+ clocks = <&gcc GCC_CAMERA_AHB_CLK>,
+ <&rpmhcc RPMH_CXO_CLK>,
+ <&rpmhcc RPMH_CXO_CLK_A>,
+ <&sleep_clk>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ #power-domain-cells = <1>;
+ };
+...
--
2.40.1
next prev parent reply other threads:[~2023-09-30 13:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 13:41 [PATCH v2 0/5] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-09-30 13:41 ` [PATCH v2 1/5] dt-bindings: clock: qcom,camcc-common.yaml: Add a common file for camcc Bryan O'Donoghue
2023-09-30 14:14 ` Krzysztof Kozlowski
2023-09-30 13:41 ` Bryan O'Donoghue [this message]
2023-09-30 14:15 ` [PATCH v2 2/5] dt-bindings: clock: Add SM8550 CAMCC yaml Krzysztof Kozlowski
2023-09-30 13:41 ` [PATCH v2 3/5] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-09-30 13:41 ` [PATCH v2 4/5] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-09-30 16:39 ` Konrad Dybcio
2023-09-30 22:53 ` Bryan O'Donoghue
2023-10-02 9:17 ` Konrad Dybcio
2023-09-30 13:41 ` [PATCH v2 5/5] arm64: boot: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
2023-09-30 14:16 ` Krzysztof Kozlowski
2023-09-30 16:41 ` Konrad Dybcio
2023-09-30 23:01 ` Bryan O'Donoghue
2023-10-02 9:56 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930134114.1816590-3-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).