Re: [PATCH v2 3/3] dt-bindings: media: imx-jpeg: Add clocks property

Conor Dooley
2023-10-02T11:16:17Z

[-- Attachment #1: Type: text/plain, Size: 2105 bytes --]

On Mon, Oct 02, 2023 at 11:18:56AM +0200, Hans Verkuil wrote:
> Rob, Conor,
>
> On 09/08/2023 22:43, Mirela Rabulea wrote:
> >> -----Original Message-----
> >> From: Rob Herring <robh@kernel.org>
> >> Sent: Wednesday, July 26, 2023 8:02 PM
> >> To: Alexander Stein <alexander.stein@ew.tq-group.com>
> >> Cc: Conor Dooley <conor@kernel.org>; Mirela Rabulea
> >> <mirela.rabulea@nxp.com>; Ming Qian <ming.qian@nxp.com>; Shijie Qin
> >> <shijie.qin@nxp.com>; Eagle Zhou <eagle.zhou@nxp.com>; Mauro Carvalho
> >> Chehab <mchehab@kernel.org>; Krzysztof Kozlowski
> >> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> >> Shawn Guo <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> >> Fabio Estevam <festevam@gmail.com>; Mark Brown <broonie@kernel.org>;
> >> Anson Huang <Anson.Huang@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
> >> Pengutronix Kernel Team <kernel@pengutronix.de>; linux-
> >> media@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> >> kernel@lists.infradead.org; linux-spi@vger.kernel.org
> >> Subject: [EXT] Re: [PATCH v2 3/3] dt-bindings: media: imx-jpeg: Add clocks
> >> property
> >>
> >> Caution: This is an external email. Please take care when clicking links or
> >> opening attachments. When in doubt, report the message using the 'Report this
> >> email' button
> >>
> >>
> >> On Tue, Jul 25, 2023 at 07:31:55AM +0200, Alexander Stein wrote:
> >>> Am Montag, 24. Juli 2023, 20:26:15 CEST schrieb Conor Dooley:
> >>>> On Mon, Jul 24, 2023 at 02:21:00PM +0200, Alexander Stein wrote:
> >>>>> i.MX8 and i.MX8X both use two clocks for accessing the periphery.
> >>>>> Add clocks and clock-names properties accordingly.
> >>>>>
> >>>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>
> Is this patch OK or do you want changes?
>
> It's a bit unclear.

It's unclear to me too at this point, but I wonder if the names should
just be removed and replaced by descriptions in the clocks property?

One of the responses here mentioned that the names aren't even needed by
hardware.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]