From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: sudeep.holla@arm.com, cristian.marussi@arm.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linus.walleij@linaro.org
Cc: Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: [RFC 0/4] gpio: add SCMI pinctrl based driver
Date: Mon, 2 Oct 2023 11:15:58 +0900 [thread overview]
Message-ID: <20231002021602.260100-1-takahiro.akashi@linaro.org> (raw)
I'm currently working on implementing SCMI pinctrl/gpio drivers
on U-Boot[1]. Although the pinctrl driver for the kernel[2] was submitted
by EPAM, it doesn't contain the gpio driver and I believe that we should
discuss a couple of points on the kernel side to finalize my design for
U-Boot.
So this RFC is intended for reviews, especially to raise some issues.
(Please note that I have *never* tested the code because I don't have
any real hardware to test SCMI on it.)
1) how to obtain a value on an input pin
All the existing gpio drivers are set to obtain a value on an input
pin by accessing the hardware directly. In SCMI case, however, this is
just impossible in its nature and must be supported via a protocol
using "Input-value" configuration type. (See the spec[3], table-23.)
The current pinconf framework is missing the feature (the pinconf
parameter and a helper function). See patch#1 and #2.
Please note that there is an issue around the pin configuration in
EPAM's current pinctrl driver as I commented[4].
2) DT bindings
I would like to propose a generic binding for SCMI pinctrl based
gpio driver. This allows a "consumer" driver to handle gpio input pins
like as other normal gpio controllers provide. (patch#4)
3) generic GPIO driver
Based on (2), I tried to prototype a generic driver in patch#3.
As you can see, there is no SCMI-specific line of code as a set of
existing helper functions, except (1), seem to be enough to implement
required interfaces.
So I'm not sure whether the driver should has a "compatibles" property
of "arm,scmi-gpio-generic".
I will appreciate any comments.
-Takahiro Akashi
[1] https://lists.denx.de/pipermail/u-boot/2023-September/529765.html
[2] https://lkml.iu.edu/hypermail/linux/kernel/2308.1/01082.html
[3] https://developer.arm.com/documentation/den0056/
[4] https://lkml.iu.edu/hypermail/linux/kernel/2308.2/07483.html
AKASHI Takahiro (4):
pinctrl: define PIN_CONFIG_INPUT
pinctrl: add pinctrl_gpio_get_config()
gpio: scmi: add SCMI pinctrl based gpio driver
dt-bindings: gpio: Add bindings for SCMI pinctrl based gpio
.../bindings/gpio/arm,scmi-gpio.yaml | 71 ++++++++
drivers/gpio/Kconfig | 8 +
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-scmi.c | 154 ++++++++++++++++++
drivers/pinctrl/core.c | 19 +++
include/linux/pinctrl/consumer.h | 8 +
include/linux/pinctrl/pinconf-generic.h | 3 +
7 files changed, 264 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/arm,scmi-gpio.yaml
create mode 100644 drivers/gpio/gpio-scmi.c
--
2.34.1
next reply other threads:[~2023-10-02 2:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 2:15 AKASHI Takahiro [this message]
2023-10-02 2:15 ` [RFC 1/4] pinctrl: define PIN_CONFIG_INPUT AKASHI Takahiro
2023-10-03 20:49 ` Linus Walleij
2023-10-04 6:54 ` AKASHI Takahiro
2023-10-02 2:16 ` [RFC 2/4] pinctrl: add pinctrl_gpio_get_config() AKASHI Takahiro
2023-10-03 20:52 ` Linus Walleij
2023-10-02 2:16 ` [RFC 3/4] gpio: scmi: add SCMI pinctrl based gpio driver AKASHI Takahiro
2023-10-03 21:35 ` Linus Walleij
2023-10-04 6:53 ` AKASHI Takahiro
2023-10-04 8:35 ` Linus Walleij
2023-10-05 2:42 ` AKASHI Takahiro
2023-10-02 2:16 ` [RFC 4/4] dt-bindings: gpio: Add bindings for SCMI pinctrl based gpio AKASHI Takahiro
2023-10-02 3:25 ` Rob Herring
2023-10-02 14:41 ` Rob Herring
2023-10-02 14:58 ` Cristian Marussi
2023-10-03 1:34 ` AKASHI Takahiro
2023-10-03 0:41 ` AKASHI Takahiro
2023-10-03 8:43 ` Krzysztof Kozlowski
2023-10-03 13:16 ` Linus Walleij
2023-10-04 7:08 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002021602.260100-1-takahiro.akashi@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=Oleksii_Moisieiev@epam.com \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).