From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E53EC147 for ; Mon, 2 Oct 2023 09:03:14 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC81EC4; Mon, 2 Oct 2023 02:03:11 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RzZh05Fr1z67g0b; Mon, 2 Oct 2023 17:01:36 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 2 Oct 2023 10:03:08 +0100 Date: Mon, 2 Oct 2023 10:03:07 +0100 From: Jonathan Cameron To: Dan Carpenter CC: David Lechner , , , , David Lechner , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?ISO-8859-1?Q?S?= =?ISO-8859-1?Q?=E1?= , Axel Haslam , Philip Molloy , , Apelete Seketeli Subject: Re: [PATCH v3 01/27] dt-bindings: iio: resolver: add devicetree bindings for ad2s1210 Message-ID: <20231002100307.000032c9@Huawei.com> In-Reply-To: <2416fa1b-86f1-40d5-b7b5-5fe85e0a8472@kadam.mountain> References: <20230929-ad2s1210-mainline-v3-0-fa4364281745@baylibre.com> <20230929-ad2s1210-mainline-v3-1-fa4364281745@baylibre.com> <2416fa1b-86f1-40d5-b7b5-5fe85e0a8472@kadam.mountain> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, 2 Oct 2023 11:02:40 +0300 Dan Carpenter wrote: > On Fri, Sep 29, 2023 at 12:23:06PM -0500, David Lechner wrote: > > From: David Lechner > > > > From: David Lechner > > > > Having two from headers kind of messes things up. The second From is > included in the body of the commit message. > > regards, > dan carpenter Strangely b4 + git am didn't do that. I was assuming I'd need to fix these by hand but didn't need to. I thanked my lucky stars for a few mins saved and didn't look into why ;) e.g. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=b3689e14415a874630f0894d8c3ac7ea01603d57 BTW, David replied to the cover letter to call out this mess up.