From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Fabio Estevam <festevam@gmail.com>,
martink@posteo.de, Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v3 7/7] media: dt-bindings: sony,imx415: Fix handling of video-interface-device
Date: Mon, 2 Oct 2023 14:07:41 -0500 [thread overview]
Message-ID: <20231002190741.GA2351787-robh@kernel.org> (raw)
In-Reply-To: <20230930145951.23433-8-jacopo.mondi@ideasonboard.com>
On Sat, Sep 30, 2023 at 04:59:51PM +0200, Jacopo Mondi wrote:
> Fix handling of properties from video-interface-device.yaml for
> Sony IMX415.
It wasn't really broken to be a fix. In any case,
Reviewed-by: Rob Herring <robh@kernel.org>
>
> All the properties described by video-interface-device.yaml are
> allowed for the image sensor, make them accepted by changing
> "additionalProperties: false" to "unevaluatedProperties: false" at the
> schema top-level.
>
> Because all properties are now accepted, there is no need to explicitly
> allow them in the schema.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
> .../devicetree/bindings/media/i2c/sony,imx415.yaml | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> index ffccf5f3c9e3..8ea3ddd251f6 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
> @@ -44,14 +44,6 @@ properties:
> description: Sensor reset (XCLR) GPIO
> maxItems: 1
>
> - flash-leds: true
> -
> - lens-focus: true
> -
> - orientation: true
> -
> - rotation: true
> -
> port:
> $ref: /schemas/graph.yaml#/$defs/port-base
>
> @@ -88,7 +80,7 @@ required:
> - ovdd-supply
> - port
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.42.0
>
prev parent reply other threads:[~2023-10-02 19:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 14:59 [PATCH v3 0/7] media: bindings: Fix handling of video-interface-device Jacopo Mondi
2023-09-30 14:59 ` [PATCH v3 1/7] media: dt-bindings: hynix,hi846: Add video-interface-device properties Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-10-03 8:27 ` Sakari Ailus
2023-10-03 9:15 ` Laurent Pinchart
2023-09-30 14:59 ` [PATCH v3 2/7] media: dt-bindings: hynix,hi846: Restrict endpoint properties Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 3/7] media: dt-bindings: ovti,ov02a10: Fix handling of video-interface-device Jacopo Mondi
2023-10-02 19:17 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 4/7] media: dt-bindings: ovti,ov4689: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 5/7] media: dt-bindings: ovti,ov5640: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 6/7] media: dt-bindings: sony,imx214: " Jacopo Mondi
2023-10-02 19:18 ` Rob Herring
2023-09-30 14:59 ` [PATCH v3 7/7] media: dt-bindings: sony,imx415: " Jacopo Mondi
2023-10-02 19:07 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002190741.GA2351787-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=michael.riesch@wolfvision.net \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).