* [PATCH V3 0/2] Support Anbernic RG351V Panel @ 2023-10-02 19:30 Chris Morgan 2023-10-02 19:30 ` [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Chris Morgan 2023-10-02 19:30 ` [PATCH V3 2/2] drm/panel: nv3051d: Add Support for " Chris Morgan 0 siblings, 2 replies; 6+ messages in thread From: Chris Morgan @ 2023-10-02 19:30 UTC (permalink / raw) To: devicetree Cc: dri-devel, conor+dt, krzysztof.kozlowski+dt, robh+dt, daniel, airlied, sam, neil.armstrong, Chris Morgan From: Chris Morgan <macromorgan@hotmail.com> Add support for the Anbernic RG351V panel. This panel is mostly identical to the one used in the 353 series, except it has a different panel ID when queried (0x4000 for the 351V, 0x3052 for the 353 panel) and will not work without the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag. Updates from V2: - Modified the driver so that we only apply the MIPI_DSI_CLOCK_NON_CONTINUOUS flag when the compatible matches a panel (the 351v) that needs it. - Updated the binding documentation to be consistent with existing panels. Updates from V1: - Revised text in devicetree documentation to remove references to specific hardware. Chris Morgan (2): dt-bindings: display: newvision,nv3051d: Add Anbernic 351V drm/panel: nv3051d: Add Support for Anbernic 351V .../bindings/display/panel/newvision,nv3051d.yaml | 5 ++--- drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 8 ++++++++ 2 files changed, 10 insertions(+), 3 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V 2023-10-02 19:30 [PATCH V3 0/2] Support Anbernic RG351V Panel Chris Morgan @ 2023-10-02 19:30 ` Chris Morgan 2023-10-02 20:09 ` Conor Dooley 2023-10-02 19:30 ` [PATCH V3 2/2] drm/panel: nv3051d: Add Support for " Chris Morgan 1 sibling, 1 reply; 6+ messages in thread From: Chris Morgan @ 2023-10-02 19:30 UTC (permalink / raw) To: devicetree Cc: dri-devel, conor+dt, krzysztof.kozlowski+dt, robh+dt, daniel, airlied, sam, neil.armstrong, Chris Morgan From: Chris Morgan <macromorgan@hotmail.com> Document the Anbernic RG351V panel, which is identical to the panel used in their 353 series except for in inclusion of an additional DSI format flag. Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- .../devicetree/bindings/display/panel/newvision,nv3051d.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml index 116c1b6030a2..cce775a87f87 100644 --- a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml @@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: NewVision NV3051D based LCD panel description: | - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, - this driver only supports the 640x480 panels found in the Anbernic RG353 - based devices. + The NewVision NV3051D is a driver chip used to drive DSI panels. maintainers: - Chris Morgan <macromorgan@hotmail.com> @@ -21,6 +19,7 @@ properties: compatible: items: - enum: + - anbernic,rg351v-panel - anbernic,rg353p-panel - anbernic,rg353v-panel - const: newvision,nv3051d -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V 2023-10-02 19:30 ` [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Chris Morgan @ 2023-10-02 20:09 ` Conor Dooley 0 siblings, 0 replies; 6+ messages in thread From: Conor Dooley @ 2023-10-02 20:09 UTC (permalink / raw) To: Chris Morgan Cc: devicetree, dri-devel, conor+dt, krzysztof.kozlowski+dt, robh+dt, daniel, airlied, sam, neil.armstrong, Chris Morgan [-- Attachment #1: Type: text/plain, Size: 1632 bytes --] On Mon, Oct 02, 2023 at 02:30:15PM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Document the Anbernic RG351V panel, which is identical to the panel > used in their 353 series except for in inclusion of an additional DSI > format flag. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > .../devicetree/bindings/display/panel/newvision,nv3051d.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > index 116c1b6030a2..cce775a87f87 100644 > --- a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > @@ -7,9 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: NewVision NV3051D based LCD panel > > description: | > - The NewVision NV3051D is a driver chip used to drive DSI panels. For now, > - this driver only supports the 640x480 panels found in the Anbernic RG353 > - based devices. > + The NewVision NV3051D is a driver chip used to drive DSI panels. > > maintainers: > - Chris Morgan <macromorgan@hotmail.com> > @@ -21,6 +19,7 @@ properties: > compatible: > items: > - enum: > + - anbernic,rg351v-panel > - anbernic,rg353p-panel > - anbernic,rg353v-panel > - const: newvision,nv3051d > -- > 2.34.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V 2023-10-02 19:30 [PATCH V3 0/2] Support Anbernic RG351V Panel Chris Morgan 2023-10-02 19:30 ` [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Chris Morgan @ 2023-10-02 19:30 ` Chris Morgan 2023-10-02 20:33 ` Jessica Zhang 1 sibling, 1 reply; 6+ messages in thread From: Chris Morgan @ 2023-10-02 19:30 UTC (permalink / raw) To: devicetree Cc: dri-devel, conor+dt, krzysztof.kozlowski+dt, robh+dt, daniel, airlied, sam, neil.armstrong, Chris Morgan From: Chris Morgan <macromorgan@hotmail.com> Add support for the Anbernic 351V. Just like the 353 series the underlying vendor is unknown/unmarked (at least not visible in a non-destructive manner). The panel had slightly different init sequences and timings in the BSP kernel, but works fine with the same ones used in the existing driver. The panel will not work without the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, and this flag prevents the 353 series from working correctly, so a new compatible string is added. Tested colors and timings using modetest and all seem to work identical to the 353 otherwise. Signed-off-by: Chris Morgan <macromorgan@hotmail.com> --- drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c index ad98dd9322b4..f644dbc8ee8a 100644 --- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c @@ -354,6 +354,7 @@ static const struct drm_panel_funcs panel_nv3051d_funcs = { static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) { struct device *dev = &dsi->dev; + struct device_node *np = dev->of_node; struct panel_nv3051d *ctx; int ret; @@ -388,6 +389,13 @@ static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; + /* + * The panel in the RG351V is identical to the 353P, except it + * requires MIPI_DSI_CLOCK_NON_CONTINUOUS to operate correctly. + */ + if (of_device_is_compatible(np, "anbernic,rg351v-panel")) + dsi->mode_flags |= MIPI_DSI_CLOCK_NON_CONTINUOUS; + drm_panel_init(&ctx->panel, &dsi->dev, &panel_nv3051d_funcs, DRM_MODE_CONNECTOR_DSI); -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V 2023-10-02 19:30 ` [PATCH V3 2/2] drm/panel: nv3051d: Add Support for " Chris Morgan @ 2023-10-02 20:33 ` Jessica Zhang 2023-10-02 23:27 ` Chris Morgan 0 siblings, 1 reply; 6+ messages in thread From: Jessica Zhang @ 2023-10-02 20:33 UTC (permalink / raw) To: Chris Morgan Cc: neil.armstrong, conor+dt, krzysztof.kozlowski+dt, sam, Chris Morgan, dri-devel, robh+dt, devicetree On 10/2/2023 12:30 PM, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add support for the Anbernic 351V. Just like the 353 series the > underlying vendor is unknown/unmarked (at least not visible in a > non-destructive manner). The panel had slightly different init > sequences and timings in the BSP kernel, but works fine with the > same ones used in the existing driver. The panel will not work without > the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, and this flag > prevents the 353 series from working correctly, so a new compatible > string is added. > > Tested colors and timings using modetest and all seem to work identical > to the 353 otherwise. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > index ad98dd9322b4..f644dbc8ee8a 100644 > --- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > @@ -354,6 +354,7 @@ static const struct drm_panel_funcs panel_nv3051d_funcs = { > static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) > { > struct device *dev = &dsi->dev; > + struct device_node *np = dev->of_node; Hi Chris, Thanks for the patch. It mostly looks good to me, but just one question here -- why not pass in `dev->of_node` directly into `of_device_is_compatible()`? Thanks, Jessica Zhang > struct panel_nv3051d *ctx; > int ret; > > @@ -388,6 +389,13 @@ static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; > > + /* > + * The panel in the RG351V is identical to the 353P, except it > + * requires MIPI_DSI_CLOCK_NON_CONTINUOUS to operate correctly. > + */ > + if (of_device_is_compatible(np, "anbernic,rg351v-panel")) > + dsi->mode_flags |= MIPI_DSI_CLOCK_NON_CONTINUOUS; > + > drm_panel_init(&ctx->panel, &dsi->dev, &panel_nv3051d_funcs, > DRM_MODE_CONNECTOR_DSI); > > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V3 2/2] drm/panel: nv3051d: Add Support for Anbernic 351V 2023-10-02 20:33 ` Jessica Zhang @ 2023-10-02 23:27 ` Chris Morgan 0 siblings, 0 replies; 6+ messages in thread From: Chris Morgan @ 2023-10-02 23:27 UTC (permalink / raw) To: Jessica Zhang Cc: Chris Morgan, neil.armstrong, conor+dt, krzysztof.kozlowski+dt, sam, dri-devel, robh+dt, devicetree On Mon, Oct 02, 2023 at 01:33:03PM -0700, Jessica Zhang wrote: > > > On 10/2/2023 12:30 PM, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Add support for the Anbernic 351V. Just like the 353 series the > > underlying vendor is unknown/unmarked (at least not visible in a > > non-destructive manner). The panel had slightly different init > > sequences and timings in the BSP kernel, but works fine with the > > same ones used in the existing driver. The panel will not work without > > the inclusion of the MIPI_DSI_CLOCK_NON_CONTINUOUS flag, and this flag > > prevents the 353 series from working correctly, so a new compatible > > string is added. > > > > Tested colors and timings using modetest and all seem to work identical > > to the 353 otherwise. > > > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > > --- > > drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > > index ad98dd9322b4..f644dbc8ee8a 100644 > > --- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > > +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c > > @@ -354,6 +354,7 @@ static const struct drm_panel_funcs panel_nv3051d_funcs = { > > static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) > > { > > struct device *dev = &dsi->dev; > > + struct device_node *np = dev->of_node; > > Hi Chris, > > Thanks for the patch. > > It mostly looks good to me, but just one question here -- why not pass in > `dev->of_node` directly into `of_device_is_compatible()`? It was an oversight on my part. I'll modify and resend, sorry about that. Thank you. > > Thanks, > > Jessica Zhang > > > struct panel_nv3051d *ctx; > > int ret; > > @@ -388,6 +389,13 @@ static int panel_nv3051d_probe(struct mipi_dsi_device *dsi) > > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > > MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET; > > + /* > > + * The panel in the RG351V is identical to the 353P, except it > > + * requires MIPI_DSI_CLOCK_NON_CONTINUOUS to operate correctly. > > + */ > > + if (of_device_is_compatible(np, "anbernic,rg351v-panel")) > > + dsi->mode_flags |= MIPI_DSI_CLOCK_NON_CONTINUOUS; > + > > drm_panel_init(&ctx->panel, &dsi->dev, &panel_nv3051d_funcs, > > DRM_MODE_CONNECTOR_DSI); > > -- > > 2.34.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-02 23:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-02 19:30 [PATCH V3 0/2] Support Anbernic RG351V Panel Chris Morgan 2023-10-02 19:30 ` [PATCH V3 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Chris Morgan 2023-10-02 20:09 ` Conor Dooley 2023-10-02 19:30 ` [PATCH V3 2/2] drm/panel: nv3051d: Add Support for " Chris Morgan 2023-10-02 20:33 ` Jessica Zhang 2023-10-02 23:27 ` Chris Morgan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).