From: Abdel Alkuor <alkuor@gmail.com>
To: heikki.krogerus@linux.intel.com,
krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ryan.eleceng@gmail.com,
robh+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, Abdel Alkuor <abdelalkuor@geotab.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v10 1/9] dt-bindings: usb: tps6598x: Add tps25750
Date: Tue, 3 Oct 2023 11:58:34 -0400 [thread overview]
Message-ID: <20231003155842.57313-2-alkuor@gmail.com> (raw)
In-Reply-To: <20231003155842.57313-1-alkuor@gmail.com>
From: Abdel Alkuor <abdelalkuor@geotab.com>
TPS25750 is USB TypeC PD controller which is a subset of TPS6598x.
Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v10:
- No changes
Changes in v9:
- Add Reviewed-by
Changes in v8:
- Define reg-names at top-level
Changes in v7:
- Define reg at top-level
- Remove description from reg-names
Changes in v6:
- Use reg property for patch address
Changes in v5:
- Add tps25750 bindings
.../devicetree/bindings/usb/ti,tps6598x.yaml | 81 ++++++++++++++++++-
1 file changed, 80 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
index 5497a60cddbc..72ac534e6ed2 100644
--- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -20,8 +20,23 @@ properties:
enum:
- ti,tps6598x
- apple,cd321x
+ - ti,tps25750
+
reg:
- maxItems: 1
+ minItems: 1
+ items:
+ - description: main PD controller address
+ - description: |
+ I2C slave address field in PBMs input data
+ which is used as the device address when writing the
+ patch for TPS25750.
+ The patch address can be any value except 0x00, 0x20,
+ 0x21, 0x22, and 0x23
+
+ reg-names:
+ items:
+ - const: main
+ - const: patch-address
wakeup-source: true
@@ -32,10 +47,42 @@ properties:
items:
- const: irq
+ firmware-name:
+ description: |
+ Should contain the name of the default patch binary
+ file located on the firmware search path which is
+ used to switch the controller into APP mode.
+ This is used when tps25750 doesn't have an EEPROM
+ connected to it.
+ maxItems: 1
+
required:
- compatible
- reg
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: ti,tps25750
+ then:
+ properties:
+ reg:
+ maxItems: 2
+
+ connector:
+ required:
+ - data-role
+
+ required:
+ - connector
+ - reg-names
+ else:
+ properties:
+ reg:
+ maxItems: 1
+
additionalProperties: true
examples:
@@ -68,4 +115,36 @@ examples:
};
};
};
+
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ typec@21 {
+ compatible = "ti,tps25750";
+ reg = <0x21>, <0x0f>;
+ reg-names = "main", "patch-address";
+
+ interrupt-parent = <&msmgpio>;
+ interrupts = <100 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "irq";
+ firmware-name = "tps25750.bin";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&typec_pins>;
+
+ typec_con0: connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ data-role = "dual";
+ port {
+ typec_ep0: endpoint {
+ remote-endpoint = <&otg_ep>;
+ };
+ };
+ };
+ };
+ };
...
--
2.34.1
next prev parent reply other threads:[~2023-10-03 16:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:58 [PATCH v10 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-10-03 15:58 ` Abdel Alkuor [this message]
2023-10-03 15:58 ` [PATCH v10 2/9] USB: typec: tsp6598x: Add cmd timeout and response delay Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 3/9] USB: typec: tps6598x: Add patch mode to tps6598x Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 4/9] USB: typec: tps6598x: Refactor tps6598x port registration Abdel Alkuor
2023-10-03 15:58 ` [PATCH v10 5/9] USB: typec: tps6598x: Add device data to of_device_id Abdel Alkuor
2023-10-10 5:55 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 6/9] USB: typec: tps6598x: Add TPS25750 support Abdel Alkuor
2023-10-10 5:57 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 7/9] USB: typec: tps6598x: Add trace for tps25750 irq Abdel Alkuor
2023-10-10 5:58 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 8/9] USB: typec: tps6598x: Add power status trace for tps25750 Abdel Alkuor
2023-10-10 5:58 ` Heikki Krogerus
2023-10-03 15:58 ` [PATCH v10 9/9] USB: typec: tps6598x: Add " Abdel Alkuor
2023-10-10 5:59 ` Heikki Krogerus
2023-10-10 7:02 ` [PATCH v10 00/14] Add TPS25750 USB type-C PD controller support Greg KH
2023-10-10 11:09 ` Abdel Alkuor
2023-10-10 11:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003155842.57313-2-alkuor@gmail.com \
--to=alkuor@gmail.com \
--cc=abdelalkuor@geotab.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).