* [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string
2023-10-04 16:39 [PATCH 0/2] mxc4005/mxc6655 OF improvements Luca Ceresoli
@ 2023-10-04 16:39 ` Luca Ceresoli
2023-10-05 8:43 ` Krzysztof Kozlowski
2023-10-06 18:53 ` Rob Herring
2023-10-04 16:39 ` [PATCH 2/2] iio: accel: mxc4005: allow module autoloading via OF compatible Luca Ceresoli
2023-10-05 16:33 ` [PATCH 0/2] mxc4005/mxc6655 OF improvements Jonathan Cameron
2 siblings, 2 replies; 7+ messages in thread
From: Luca Ceresoli @ 2023-10-04 16:39 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Cameron,
Jonathan Cameron, Lars-Peter Clausen
Cc: Thomas Petazzoni, Rob Herring, devicetree, linux-kernel,
linux-iio, Luca Ceresoli
The correct name of this chip is MXC4005, not MX4005. This is confirmed
both by the manufacturer website and by the title of the original commit,
which added other MXCxxxx devices as well but only this one misses a "c" in
the compatible string.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Fixes: d9bf5d37fd58 ("dt-bindings:trivial-devices: Add memsic,mxc4005/mxc6255/mxc6655 entries")
---
The original commit date being April 1st is possibly clarifying the origin
of the issue! :)
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index cd58179ae337..430a814f64a5 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -232,7 +232,7 @@ properties:
# MEMSIC magnetometer
- memsic,mmc35240
# MEMSIC 3-axis accelerometer
- - memsic,mx4005
+ - memsic,mxc4005
# MEMSIC 2-axis 8-bit digital accelerometer
- memsic,mxc6225
# MEMSIC 2-axis 8-bit digital accelerometer
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string
2023-10-04 16:39 ` [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string Luca Ceresoli
@ 2023-10-05 8:43 ` Krzysztof Kozlowski
2023-10-06 18:53 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 8:43 UTC (permalink / raw)
To: Luca Ceresoli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jonathan Cameron, Jonathan Cameron, Lars-Peter Clausen
Cc: Thomas Petazzoni, Rob Herring, devicetree, linux-kernel,
linux-iio
On 04/10/2023 18:39, Luca Ceresoli wrote:
> The correct name of this chip is MXC4005, not MX4005. This is confirmed
> both by the manufacturer website and by the title of the original commit,
> which added other MXCxxxx devices as well but only this one misses a "c" in
> the compatible string.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Fixes: d9bf5d37fd58 ("dt-bindings:trivial-devices: Add memsic,mxc4005/mxc6255/mxc6655 entries")
>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string
2023-10-04 16:39 ` [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string Luca Ceresoli
2023-10-05 8:43 ` Krzysztof Kozlowski
@ 2023-10-06 18:53 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-10-06 18:53 UTC (permalink / raw)
To: Luca Ceresoli
Cc: linux-kernel, Rob Herring, Thomas Petazzoni, Jonathan Cameron,
Jonathan Cameron, devicetree, Lars-Peter Clausen,
Krzysztof Kozlowski, Conor Dooley, linux-iio
On Wed, 04 Oct 2023 18:39:27 +0200, Luca Ceresoli wrote:
> The correct name of this chip is MXC4005, not MX4005. This is confirmed
> both by the manufacturer website and by the title of the original commit,
> which added other MXCxxxx devices as well but only this one misses a "c" in
> the compatible string.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Fixes: d9bf5d37fd58 ("dt-bindings:trivial-devices: Add memsic,mxc4005/mxc6255/mxc6655 entries")
>
> ---
>
> The original commit date being April 1st is possibly clarifying the origin
> of the issue! :)
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] iio: accel: mxc4005: allow module autoloading via OF compatible
2023-10-04 16:39 [PATCH 0/2] mxc4005/mxc6655 OF improvements Luca Ceresoli
2023-10-04 16:39 ` [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string Luca Ceresoli
@ 2023-10-04 16:39 ` Luca Ceresoli
2023-10-05 8:45 ` Krzysztof Kozlowski
2023-10-05 16:33 ` [PATCH 0/2] mxc4005/mxc6655 OF improvements Jonathan Cameron
2 siblings, 1 reply; 7+ messages in thread
From: Luca Ceresoli @ 2023-10-04 16:39 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Cameron,
Jonathan Cameron, Lars-Peter Clausen
Cc: Thomas Petazzoni, Rob Herring, devicetree, linux-kernel,
linux-iio, Luca Ceresoli
Add OF device table with compatible strings to allow automatic module
loading.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/iio/accel/mxc4005.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
index 75d142bc14b4..41182531feb5 100644
--- a/drivers/iio/accel/mxc4005.c
+++ b/drivers/iio/accel/mxc4005.c
@@ -476,6 +476,13 @@ static const struct acpi_device_id mxc4005_acpi_match[] = {
};
MODULE_DEVICE_TABLE(acpi, mxc4005_acpi_match);
+static const struct of_device_id mxc4005_of_match[] = {
+ { .compatible = "memsic,mxc4005", },
+ { .compatible = "memsic,mxc6655", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mxc4005_of_match);
+
static const struct i2c_device_id mxc4005_id[] = {
{"mxc4005", 0},
{"mxc6655", 0},
@@ -487,6 +494,7 @@ static struct i2c_driver mxc4005_driver = {
.driver = {
.name = MXC4005_DRV_NAME,
.acpi_match_table = ACPI_PTR(mxc4005_acpi_match),
+ .of_match_table = mxc4005_of_match,
},
.probe = mxc4005_probe,
.id_table = mxc4005_id,
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: accel: mxc4005: allow module autoloading via OF compatible
2023-10-04 16:39 ` [PATCH 2/2] iio: accel: mxc4005: allow module autoloading via OF compatible Luca Ceresoli
@ 2023-10-05 8:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-05 8:45 UTC (permalink / raw)
To: Luca Ceresoli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jonathan Cameron, Jonathan Cameron, Lars-Peter Clausen
Cc: Thomas Petazzoni, Rob Herring, devicetree, linux-kernel,
linux-iio
On 04/10/2023 18:39, Luca Ceresoli wrote:
> Add OF device table with compatible strings to allow automatic module
> loading.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/iio/accel/mxc4005.c | 8 ++++++++
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] mxc4005/mxc6655 OF improvements
2023-10-04 16:39 [PATCH 0/2] mxc4005/mxc6655 OF improvements Luca Ceresoli
2023-10-04 16:39 ` [PATCH 1/2] dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string Luca Ceresoli
2023-10-04 16:39 ` [PATCH 2/2] iio: accel: mxc4005: allow module autoloading via OF compatible Luca Ceresoli
@ 2023-10-05 16:33 ` Jonathan Cameron
2 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2023-10-05 16:33 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jonathan Cameron,
Lars-Peter Clausen, Thomas Petazzoni, Rob Herring, devicetree,
linux-kernel, linux-iio
On Wed, 04 Oct 2023 18:39:26 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> This small series fixes the compatible string of MXC4005 in the bindings
> and adds support for OF-based autoloading of the mxc4005 driver.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> Luca Ceresoli (2):
> dt-bindings: trivial-devices: Fix MEMSIC MXC4005 compatible string
> iio: accel: mxc4005: allow module autoloading via OF compatible
>
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 +-
> drivers/iio/accel/mxc4005.c | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
> ---
> base-commit: 8a749fd1a8720d4619c91c8b6e7528c0a355c0aa
> change-id: 20231004-mxc4005-device-tree-support-40ae517a42e9
>
> Best regards,
Series applied to the togreg branch of iio.git and pushed out as testing
so 0-day can see if it can find anything we missed.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 7+ messages in thread