From: "Alvin Šipraga" <alvin@pqrs.dk>
To: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
�ipraga <alsi@bang-olufsen.dk>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] clk: si5351: add option to adjust PLL without glitches
Date: Wed, 4 Oct 2023 08:35:26 +0200 [thread overview]
Message-ID: <20231004063712.3348978-1-alvin@pqrs.dk> (raw)
From: Alvin Šipraga <alsi@bang-olufsen.dk>
This series intends to address a problem I had when using the Si5351A as
a runtime adjustable audio bit clock. The basic issue is that the driver
in its current form unconditionally resets the PLL whenever adjusting
its rate. But this reset causes an unwanted ~1.4 ms LOW signal glitch in
the clock output.
As a remedy, a new property is added to control the reset behaviour of
the PLLs more precisely. In the process I also converted the bindings to
YAML.
Changes:
v1 -> v2:
- address Rob's comments on the two dt-bindings patches
- new patch to correct the clock node names in the only upstream device
tree using si5351
Alvin Šipraga (4):
dt-bindings: clock: si5351: convert to yaml
ARM: dts: dove-cubox: fix si5351 node names
dt-bindings: clock: si5351: add PLL reset mode property
clk: si5351: allow PLLs to be adjusted without reset
.../bindings/clock/silabs,si5351.txt | 126 --------
.../bindings/clock/silabs,si5351.yaml | 277 ++++++++++++++++++
arch/arm/boot/dts/marvell/dove-cubox.dts | 4 +-
drivers/clk/clk-si5351.c | 47 ++-
include/linux/platform_data/si5351.h | 2 +
5 files changed, 325 insertions(+), 131 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/silabs,si5351.txt
create mode 100644 Documentation/devicetree/bindings/clock/silabs,si5351.yaml
--
2.42.0
next reply other threads:[~2023-10-04 6:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 6:35 Alvin Šipraga [this message]
2023-10-04 6:35 ` [PATCH v2 1/4] dt-bindings: clock: si5351: convert to yaml Alvin Šipraga
2023-10-04 14:39 ` Rob Herring
2023-10-04 21:39 ` Alvin Šipraga
2023-10-10 14:50 ` Rob Herring
2023-10-14 14:00 ` Alvin Šipraga
2023-10-04 6:35 ` [PATCH v2 2/4] ARM: dts: dove-cubox: fix si5351 node names Alvin Šipraga
2023-10-05 7:57 ` Krzysztof Kozlowski
2024-01-26 11:22 ` (subset) " Krzysztof Kozlowski
2023-10-04 6:35 ` [PATCH v2 3/4] dt-bindings: clock: si5351: add PLL reset mode property Alvin Šipraga
2023-10-04 6:35 ` [PATCH v2 4/4] clk: si5351: allow PLLs to be adjusted without reset Alvin Šipraga
2023-10-07 17:54 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004063712.3348978-1-alvin@pqrs.dk \
--to=alvin@pqrs.dk \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).