devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: devicetree@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Tom Rini" <trini@konsulko.com>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	linux-mtd@lists.infradead.org,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Pratyush Yadav" <ptyadav@amazon.de>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Richard Weinberger" <richard@nod.at>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible
Date: Wed, 4 Oct 2023 09:36:20 +0200	[thread overview]
Message-ID: <20231004093620.2b1d6917@xps-13> (raw)
In-Reply-To: <20231002174948.1015223-1-sjg@chromium.org>

Hi Simon,

sjg@chromium.org wrote on Mon,  2 Oct 2023 11:49:40 -0600:

> Add a compatible string for binman, so we can extend fixed-partitions
> in various ways.

I've been thinking at the proper way to describe the binman partitions.
I am wondering if we should really extend the fixed-partitions
schema. This description is really basic and kind of supposed to remain
like that. Instead, I wonder if we should not just keep the binman
compatible alone, like many others already. This way it would be very clear
what is expected and allowed in both cases. I am thinking about
something like that:

	Documentation/devicetree/bindings/mtd/partitions/brcm,bcm4908-partitions.yaml 

this file is also referenced there (but this patch does the same, which
is what I'd expect):

	Documentation/devicetree/bindings/mtd/partitions/partitions.yaml

I'll let the binding maintainers judge whether they think it's
relevant, it's not a strong opposition.

> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---

[...]

> +properties:
> +  compatible:
> +    const: binman

Right now this does not fit (I believe) the example. But if we no
longer extend fixed-partitions but just create binman.yaml, this will
probably be enough.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    partitions {
> +        compatible = "binman", "fixed-partitions";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        partition@100000 {
> +            label = "u-boot";
> +            reg = <0x100000 0xf00000>;
> +        };
> +    };

Thanks,
Miquèl

  parent reply	other threads:[~2023-10-04  7:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02 17:49 [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible Simon Glass
2023-10-02 17:49 ` [PATCH v2 2/3] dt-bindings: mtd: binman-partition: Add binman labels Simon Glass
2023-10-02 17:49 ` [PATCH v2 3/3] dt-bindings: mtd: binman-partitions: Add alignment properties Simon Glass
2023-10-04  7:36 ` Miquel Raynal [this message]
2023-10-04 11:34   ` [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible Michael Walle
2023-10-04 16:05     ` Simon Glass
2023-10-04 17:16       ` Michael Walle
2023-10-04 18:08         ` Simon Glass
2023-10-05  8:54           ` Michael Walle
2023-10-05 13:28             ` Simon Glass
2023-10-05 15:01               ` Simon Glass
2023-10-06  8:37               ` Michael Walle
2023-10-06 12:39                 ` Simon Glass
2023-10-06 16:11                 ` Rob Herring
2023-10-09 19:52                   ` Simon Glass
2023-10-04 16:05   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231004093620.2b1d6917@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=ptyadav@amazon.de \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).