From: Andreas Kemnade <andreas@kemnade.info>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible
Date: Wed, 4 Oct 2023 13:03:53 +0200 [thread overview]
Message-ID: <20231004130353.01228376@aktux> (raw)
In-Reply-To: <12323F42-3611-4685-8981-F6A18C4A5862@goldelico.com>
On Wed, 4 Oct 2023 12:50:16 +0200
"H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> Hi Andreas,
>
> > Am 04.10.2023 um 08:53 schrieb Andreas Kemnade <andreas@kemnade.info>:
> >
> > Drop omap36xx compatible as done in other omap3630 devices.
> > This has apparently fallen through the lattice.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> > index b6b27e93857f..3661340009e7 100644
> > --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> > @@ -11,7 +11,7 @@
> >
> > / {
> > model = "OMAP3 GTA04";
> > - compatible = "goldelico,gta04", "ti,omap3630", "ti,omap36xx", "ti,omap3";
>
> there seem to be some more references to ti,omap36xx:
>
> arch/arm/boot/dts/ti/omap/omap3-lilly-a83x.dtsi: compatible = "incostartec,omap3-lilly-a83x", "ti,omap3630", "ti,omap36xx", "ti,omap3";
apperently all the dtsi are fallen through the lattice when handling the dts.
> arch/arm/mach-omap2/board-generic.c: "ti,omap36xx",
> drivers/clk/ti/dpll.c: of_machine_is_compatible("ti,omap36xx")) &&
> drivers/cpufreq/ti-cpufreq.c: { .compatible = "ti,omap36xx", .data = &omap36xx_soc_data, },
>
> So are you sure that we can remove it without replacement or code fixes in dpll and cpufreq (board-generic is probably no issue)?
>
see discussion of:
commit e341f338180c84cd98af3016cf5bcfde45a041fb
Author: Andrew Davis <afd@ti.com>
Date: Thu Feb 16 09:33:38 2023 -0600
ARM: dts: omap: Drop ti,omap36xx compatible
all the places also basically check for omap36xx || omap3630.
Regards,
Andreas
next prev parent reply other threads:[~2023-10-04 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 6:53 [PATCH] ARM: dts: omap3-gta04: Drop superfluous omap36xx compatible Andreas Kemnade
2023-10-04 11:02 ` H. Nikolaus Schaller
[not found] ` <12323F42-3611-4685-8981-F6A18C4A5862@goldelico.com>
2023-10-04 11:03 ` Andreas Kemnade [this message]
2023-10-04 11:39 ` H. Nikolaus Schaller
2023-10-04 11:54 ` Andreas Kemnade
2023-10-04 12:42 ` H. Nikolaus Schaller
2023-10-04 12:50 ` H. Nikolaus Schaller
2023-10-07 6:44 ` Tony Lindgren
2023-10-07 6:54 ` H. Nikolaus Schaller
2023-10-07 6:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004130353.01228376@aktux \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).