From: Conor Dooley <conor@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: add missing reset-gpios constrain
Date: Thu, 5 Oct 2023 11:41:07 +0100 [thread overview]
Message-ID: <20231005-thrift-backer-d2f58a1bd441@spud> (raw)
In-Reply-To: <20231005083650.92222-1-krzysztof.kozlowski@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 2884 bytes --]
On Thu, Oct 05, 2023 at 10:36:50AM +0200, Krzysztof Kozlowski wrote:
> The Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml
> schema does not enforce number of reset GPIOs, thus each device binding
> must do it.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml | 3 ++-
> Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml | 3 ++-
> 4 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> index 2594fa192f93..2a04906531fb 100644
> --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74115.yaml
> @@ -32,7 +32,8 @@ properties:
>
> spi-cpol: true
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> interrupts:
> minItems: 1
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> index 4e508bfcc9d8..5121685337b5 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
> @@ -78,7 +78,8 @@ properties:
> - const: -1000
> - const: 22000
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> adi,dc-dc-ilim-microamp:
> enum: [150000, 200000, 250000, 300000, 350000, 400000]
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> index b9b5beac33b2..5b6cde86b5a5 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4403.yaml
> @@ -23,7 +23,8 @@ properties:
> maxItems: 1
> description: Connected to ADC_RDY pin.
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> index 2958c4ca75b4..167d10bd60af 100644
> --- a/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> +++ b/Documentation/devicetree/bindings/iio/health/ti,afe4404.yaml
> @@ -23,7 +23,8 @@ properties:
> maxItems: 1
> description: Connected to ADC_RDY pin.
>
> - reset-gpios: true
> + reset-gpios:
> + maxItems: 1
>
> additionalProperties: false
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-05 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 8:36 [PATCH] dt-bindings: iio: add missing reset-gpios constrain Krzysztof Kozlowski
2023-10-05 10:41 ` Conor Dooley [this message]
2023-10-10 16:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005-thrift-backer-d2f58a1bd441@spud \
--to=conor@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=cosmin.tanislav@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).