From: Jakub Kicinski <kuba@kernel.org>
To: Rohan G Thomas <rohan.g.thomas@intel.com>
Cc: alexandre.torgue@foss.st.com, andriy.shevchenko@linux.intel.com,
davem@davemloft.net, devicetree@vger.kernel.org,
edumazet@google.com, fancer.lancer@gmail.com,
joabreu@synopsys.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Date: Thu, 5 Oct 2023 07:05:38 -0700 [thread overview]
Message-ID: <20231005070538.0826bf9d@kernel.org> (raw)
In-Reply-To: <20231005121441.22916-1-rohan.g.thomas@intel.com>
On Thu, 5 Oct 2023 20:14:41 +0800 Rohan G Thomas wrote:
> > So the question now is whether we want Rohan to do this conversion _first_,
> > in DW QoS 5, and then add xgmac part. Or the patch should go in as is and
> > you'll follow up with the conversion?
>
> If agreed, this commit can go in. I can submit another patch with the
> refactoring suggested by Serge.
Did you miss the emphasis I put on the word "first" in my reply?
Cleanup first, nobody will be keeping track whether your fulfilled
your promises or not :|
next prev parent reply other threads:[~2023-10-05 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 3:10 [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling Rohan G Thomas
2023-09-26 11:25 ` Serge Semin
2023-10-02 20:55 ` Jakub Kicinski
2023-10-03 11:12 ` Serge Semin
2023-10-04 16:26 ` Jakub Kicinski
2023-10-05 12:14 ` Rohan G Thomas
2023-10-05 14:05 ` Jakub Kicinski [this message]
2023-10-06 7:23 ` Rohan G Thomas
2023-10-06 10:08 ` Serge Semin
2023-10-06 13:35 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005070538.0826bf9d@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rohan.g.thomas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).