Re: [PATCH v23 12/16] PCI: add T_PVPERL macro

Bjorn Helgaas
2023-10-05T14:49:45Z

On Tue, Sep 26, 2023 at 09:24:27PM +0900, Yoshihiro Shimoda wrote:
> According to the PCI Express Card Electromechanical Specification,
> Power stable to PERST# inactive interval is 100 ms as minimum.
> So, add the macro to use PCIe controller drivers.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>

Beautiful, thank you!

No need to repost; whoever applies this, please:

- s/add/Add/ in subject
- Add sec 2.9.2 to spec citation in commit log and comment (can use
"PCIe CEM r5.0, sec 2.9.2" for brevity)

> ---
> drivers/pci/pci.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 39a8932dc340..5ecbcf041179 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -13,6 +13,9 @@
>
> #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000
>
> +/* Power stable to PERST# inactive from PCIe card Electromechanical Spec */
> +#define PCIE_T_PVPERL_MS 100
> +
> /*
> * PCIe r6.0, sec 5.3.3.2.1 <PME Synchronization>
> * Recommends 1ms to 10ms timeout to check L2 ready.
> --
> 2.25.1
>