From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, loic.poulain@linaro.org,
rfoss@kernel.org, andi.shyti@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
todor.too@gmail.com, mchehab@kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding
Date: Fri, 6 Oct 2023 10:12:17 -0500 [thread overview]
Message-ID: <20231006151217.GA3943830-robh@kernel.org> (raw)
In-Reply-To: <ace84d7f-d332-4598-a95d-634c1d17f852@linaro.org>
On Fri, Oct 06, 2023 at 02:33:42PM +0200, Krzysztof Kozlowski wrote:
> On 06/10/2023 14:01, Bryan O'Donoghue wrote:
> > Add bindings for qcom,sc8280xp-camss in order to support the camera
> > subsystem for sc8280xp as found in the Lenovo x13s Laptop.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > ---
> > .../bindings/media/qcom,sc8280xp-camss.yaml | 598 ++++++++++++++++++
> > 1 file changed, 598 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> > new file mode 100644
> > index 000000000000..46d2da4ad373
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> > @@ -0,0 +1,598 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/qcom,sc8280xp-camss.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm CAMSS
>
> Instead something like:
> Qualcomm SC8280xp Camera SubSystem (CAMSS)
> ?
>
> > +
> > +maintainers:
> > + - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> > +
> > +description: |
> > + The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
> > +
> > +properties:
> > + compatible:
> > + const: qcom,sc8280xp-camss
> > +
> > + clocks:
> > + minItems: 63
>
> You can drop minItems if they equal maxItems.
>
> > + maxItems: 63
> > +
> > + clock-names:
> > + items:
> > + - const: camnoc_axi
> > + - const: camnoc_axi_src
> > + - const: cpas_ahb
> > + - const: cphy_rx_src
> > + - const: csiphy0
> > + - const: csiphy0_timer_src
> > + - const: csiphy0_timer
> > + - const: csiphy1
> > + - const: csiphy1_timer_src
> > + - const: csiphy1_timer
> > + - const: csiphy2
> > + - const: csiphy2_timer_src
> > + - const: csiphy2_timer
> > + - const: csiphy3
> > + - const: csiphy3_timer_src
> > + - const: csiphy3_timer
> > + - const: vfe0_axi
> > + - const: vfe0_src
> > + - const: vfe0
> > + - const: vfe0_cphy_rx
> > + - const: vfe0_csid_src
> > + - const: vfe0_csid
> > + - const: vfe1_axi
> > + - const: vfe1_src
> > + - const: vfe1
> > + - const: vfe1_cphy_rx
> > + - const: vfe1_csid_src
> > + - const: vfe1_csid
> > + - const: vfe2_axi
> > + - const: vfe2_src
> > + - const: vfe2
> > + - const: vfe2_cphy_rx
> > + - const: vfe2_csid_src
> > + - const: vfe2_csid
> > + - const: vfe3_axi
> > + - const: vfe3_src
> > + - const: vfe3
> > + - const: vfe3_cphy_rx
> > + - const: vfe3_csid_src
> > + - const: vfe3_csid
> > + - const: vfe_lite0_src
> > + - const: vfe_lite0
> > + - const: vfe_lite0_cphy_rx
> > + - const: vfe_lite0_csid_src
> > + - const: vfe_lite0_csid
> > + - const: vfe_lite1_src
> > + - const: vfe_lite1
> > + - const: vfe_lite1_cphy_rx
> > + - const: vfe_lite1_csid_src
> > + - const: vfe_lite1_csid
> > + - const: vfe_lite2_src
> > + - const: vfe_lite2
> > + - const: vfe_lite2_cphy_rx
> > + - const: vfe_lite2_csid_src
> > + - const: vfe_lite2_csid
> > + - const: vfe_lite3_src
> > + - const: vfe_lite3
> > + - const: vfe_lite3_cphy_rx
> > + - const: vfe_lite3_csid_src
> > + - const: vfe_lite3_csid
> > + - const: gcc_axi_hf
> > + - const: gcc_axi_sf
> > + - const: slow_ahb_src
> > +
> > + interrupts:
> > + minItems: 20
>
> You can drop minItems if they equal maxItems.
>
>
> > + maxItems: 20
> > +
> > + interrupt-names:
> > + items:
> > + - const: csid1_lite
> > + - const: vfe_lite1
> > + - const: csiphy3
> > + - const: csid0
> > + - const: vfe0
> > + - const: csid1
> > + - const: vfe1
> > + - const: csid0_lite
> > + - const: vfe_lite0
> > + - const: csiphy0
> > + - const: csiphy1
> > + - const: csiphy2
> > + - const: csid2
> > + - const: vfe2
> > + - const: csid3_lite
> > + - const: csid2_lite
> > + - const: vfe_lite3
> > + - const: vfe_lite2
> > + - const: csid3
> > + - const: vfe3
> > +
> > + iommus:
> > + minItems: 16
>
> You can drop minItems if they equal maxItems.
>
> > + maxItems: 16
> > +
> > + interconnects:
> > + minItems: 4
>
> You can drop minItems if they equal maxItems.
>
>
> > + maxItems: 4
> > +
> > + interconnect-names:
> > + items:
> > + - const: cam_ahb
> > + - const: cam_hf_mnoc
> > + - const: cam_sf_mnoc
> > + - const: cam_sf_icp_mnoc
> > +
> > + power-domains:
> > + items:
> > + - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller.
> > + - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller.
> > + - description: IFE2 GDSC - Image Front End, Global Distributed Switch Controller.
> > + - description: IFE3 GDSC - Image Front End, Global Distributed Switch Controller.
> > + - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller.
> > +
> > + power-domain-names:
> > + items:
> > + - description: ife0
> > + - description: ife1
> > + - description: ife2
> > + - description: ife3
> > + - description: top
> > +
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
>
> On this level of indentation:
> additionalProperties: false
No, because then #size-cells/#address-cells won't be allowed.
Rob
next prev parent reply other threads:[~2023-10-06 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:01 [PATCH 0/5] Add sc8280xp CCI and CAMSS core dtsi Bryan O'Donoghue
2023-10-06 12:01 ` [PATCH 1/5] dt-bindings: i2c: qcom-cci: Document sc8280xp compatible Bryan O'Donoghue
2023-10-06 12:29 ` Krzysztof Kozlowski
2023-10-10 19:44 ` Wolfram Sang
2023-10-10 22:25 ` Bryan O'Donoghue
2023-10-11 6:28 ` Wolfram Sang
2023-10-06 12:01 ` [PATCH 2/5] i2c: qcom-cci: Add " Bryan O'Donoghue
2023-10-06 23:21 ` Konrad Dybcio
2023-10-08 21:28 ` Andi Shyti
2023-10-08 22:13 ` Bryan O'Donoghue
2023-10-08 22:26 ` Bryan O'Donoghue
2023-10-09 10:16 ` Konrad Dybcio
2023-10-06 12:01 ` [PATCH 3/5] arm64: dts: qcom: sc8280xp: camss: Add CCI definitions Bryan O'Donoghue
2023-10-06 12:01 ` [PATCH 4/5] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding Bryan O'Donoghue
2023-10-06 12:33 ` Krzysztof Kozlowski
2023-10-06 12:52 ` Bryan O'Donoghue
2023-10-06 13:42 ` Krzysztof Kozlowski
2023-10-06 15:12 ` Rob Herring [this message]
2023-10-06 13:58 ` Rob Herring
2023-10-06 12:01 ` [PATCH 5/5] arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006151217.GA3943830-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).