From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE7F30FA0 for ; Fri, 6 Oct 2023 19:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B0AF95; Fri, 6 Oct 2023 12:30:22 -0700 (PDT) Received: from p5dc58044.dip0.t-ipconnect.de ([93.197.128.68] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qoqWU-004b0J-U9; Fri, 06 Oct 2023 21:30:06 +0200 Date: Fri, 6 Oct 2023 21:30:03 +0200 From: Andreas Kemnade To: Tony Lindgren Cc: =?UTF-8?B?UMOpdGVy?= Ujfalusi , bcousson@baylibre.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, jarkko.nikula@bitmer.com, dmitry.torokhov@gmail.com, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 1/3] ASoC: ti: omap-mcbsp: Ignore errors for getting fck_src Message-ID: <20231006213003.0fbac87a@aktux> In-Reply-To: <20231006102348.GK34982@atomide.com> References: <20230705190324.355282-1-andreas@kemnade.info> <20230705190324.355282-2-andreas@kemnade.info> <7d58d52d-2087-45af-b29e-2515b63ead13@gmail.com> <20230920063353.GQ5285@atomide.com> <20230921121626.GT5285@atomide.com> <20231006102348.GK34982@atomide.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, 6 Oct 2023 13:23:48 +0300 Tony Lindgren wrote: > * Tony Lindgren [230921 20:34]: > > * P=C3=A9ter Ujfalusi [230920 17:40]: =20 > > > It is not the parent's fck, it is the PRCM clock which is selected as > > > the sourcee of the clock generator (CLKS) for BCLK/FSYNC. That is the > > > functional clock as well for the McBSP instance. =20 > >=20 > > Oh OK > > =20 > > > Out of reset it is using the PRCM source which is fine in all current= users. > > > I would do this fix or workaround in a different way: instead of > > > ignoring the error, avoid it in the first place. Do nothing if the > > > already selected clock is requested. > > > That would remove the error and will fail in case the reparenting is = not > > > working -> boards will know this and might be able to do something ab= out > > > it in a reasonable way. =20 >=20 > Here's what I think the regression fix for omap4 clocks would be, the > old main_clk is not the same as the module clock that we get by default. > If this looks OK I'll do a similar fix also for omap5. >=20 > Or is something else also needed? >=20 hmm, audio output works, the waring is away, but something new is here: omap-mcbsp 40124000.mcbsp: Runtime PM usage count underflow! # cat /sys/bus/platform/devices/40124000.mcbsp/power/runtime_status=20 active even with no sound. Regards, Andreas